Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] nvme: allow timed-out ios to retry
Date: Sun, 17 Sep 2017 17:27:13 -0700	[thread overview]
Message-ID: <20170918002713.GA20043@infradead.org> (raw)
In-Reply-To: <20170907203759.GA2832@localhost.localdomain>

On Thu, Sep 07, 2017@04:37:59PM -0400, Keith Busch wrote:
> I'm a bit conflicted on this. While it'd be nice to give commands a chance
> to succeed after a timeout handling's controller reset, some uses would
> rather a command fail fast than succeed slow, and this change could keep
> a request outstanding for a very long time.

That's what we have the fastfail flags for, which we set for all
the internal commands for example? and evaluate just a little bit
above the start_time line.

  parent reply	other threads:[~2017-09-18  0:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-07 20:18 [PATCH] nvme: allow timed-out ios to retry James Smart
2017-09-07 20:37 ` Keith Busch
2017-09-08 16:11   ` James Smart
2017-09-18 17:15     ` James Smart
2017-09-18 17:24       ` Keith Busch
2017-09-18 17:42         ` James Smart
2017-09-18 17:49           ` Keith Busch
2017-09-18  0:27   ` Christoph Hellwig [this message]
2017-09-20 11:27     ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170918002713.GA20043@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox