From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv3 1/5] nvme: Centralize AEN defines
Date: Thu, 9 Nov 2017 10:23:38 +0100 [thread overview]
Message-ID: <20171109092338.GA17120@lst.de> (raw)
In-Reply-To: <20171107221314.27822-2-keith.busch@intel.com>
Looks fine:
Reviewed-by: Christoph Hellwig <hch at lst.de>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index fd1d4508a612..89ffa7eed2fd 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -90,6 +90,14 @@ enum {
> };
>
> #define NVME_AQ_DEPTH 32
> +#define NVME_NR_AEN_COMMANDS 1
> +#define NVME_AQ_BLK_MQ_DEPTH (NVME_AQ_DEPTH - NVME_NR_AEN_COMMANDS)
> +
> +/*
> + * Subtract one to leave an empty queue entry for 'Full Queue' condition. See
> + * NVM-Express 1.2 specification, section 4.1.2.
> + */
> +#define NVME_AQ_MQ_TAG_DEPTH (NVME_AQ_BLK_MQ_DEPTH - 1)
But none of these (including NVME_AQ_DEPTH) really is a protocol
constant, so this should probably move to drivers/nvme/host/nvme.h.
No need to do that in this patchseries, though.
next prev parent reply other threads:[~2017-11-09 9:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 22:13 [PATCHv3 0/5] Asynchronous events for udev Keith Busch
2017-11-07 22:13 ` [PATCHv3 1/5] nvme: Centralize AEN defines Keith Busch
2017-11-08 1:37 ` Guan Junxiong
2017-11-09 9:23 ` Christoph Hellwig [this message]
2017-11-07 22:13 ` [PATCHv3 2/5] nvme/fc: remove unused "queue_size" field Keith Busch
[not found] ` <45c5bfad-4854-2e01-905e-bcd8cbf42314@broadcom.com>
2017-11-08 0:04 ` Keith Busch
2017-11-08 1:38 ` Guan Junxiong
2017-11-09 9:23 ` Christoph Hellwig
2017-11-07 22:13 ` [PATCHv3 3/5] nvme: Single AEN request Keith Busch
2017-11-08 1:35 ` Guan Junxiong
2017-11-09 9:24 ` Christoph Hellwig
2017-11-09 16:04 ` Keith Busch
2017-11-09 9:25 ` Christoph Hellwig
2017-11-07 22:13 ` [PATCHv3 4/5] nvme: Unexport starting async event work Keith Busch
2017-11-08 1:39 ` Guan Junxiong
2017-11-07 22:13 ` [PATCHv3 5/5] nvme: Send uevent for some asynchronous events Keith Busch
2017-11-08 1:40 ` Guan Junxiong
2017-11-09 9:27 ` Christoph Hellwig
2017-11-09 16:18 ` Keith Busch
2017-11-09 16:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109092338.GA17120@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox