From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv3 5/5] nvme: Send uevent for some asynchronous events
Date: Thu, 9 Nov 2017 09:18:46 -0700 [thread overview]
Message-ID: <20171109161846.GE25017@localhost.localdomain> (raw)
In-Reply-To: <20171109092702.GE17120@lst.de>
On Thu, Nov 09, 2017@10:27:03AM +0100, Christoph Hellwig wrote:
> On Tue, Nov 07, 2017@03:13:14PM -0700, Keith Busch wrote:
> > +static void nvme_aen_uevent(struct nvme_ctrl *ctrl)
> > +{
> > + char *envp[2] = {NULL, NULL};
> > + u32 aen = ctrl->aen;
> > +
> > + ctrl->aen = 0;
>
> Seems like we should use cmpxchg on aen.
> > + ctrl->aen = result;
>
> Can we call the field aen_result?
>
> Given that the rest of the series looks good I'd be tempted to just
> fix that up and apply it. Are you ok with that?
Thanks, the suggestions sound good to me. If you want to edit the commit
when applying, I would much appreciate.
next prev parent reply other threads:[~2017-11-09 16:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 22:13 [PATCHv3 0/5] Asynchronous events for udev Keith Busch
2017-11-07 22:13 ` [PATCHv3 1/5] nvme: Centralize AEN defines Keith Busch
2017-11-08 1:37 ` Guan Junxiong
2017-11-09 9:23 ` Christoph Hellwig
2017-11-07 22:13 ` [PATCHv3 2/5] nvme/fc: remove unused "queue_size" field Keith Busch
[not found] ` <45c5bfad-4854-2e01-905e-bcd8cbf42314@broadcom.com>
2017-11-08 0:04 ` Keith Busch
2017-11-08 1:38 ` Guan Junxiong
2017-11-09 9:23 ` Christoph Hellwig
2017-11-07 22:13 ` [PATCHv3 3/5] nvme: Single AEN request Keith Busch
2017-11-08 1:35 ` Guan Junxiong
2017-11-09 9:24 ` Christoph Hellwig
2017-11-09 16:04 ` Keith Busch
2017-11-09 9:25 ` Christoph Hellwig
2017-11-07 22:13 ` [PATCHv3 4/5] nvme: Unexport starting async event work Keith Busch
2017-11-08 1:39 ` Guan Junxiong
2017-11-07 22:13 ` [PATCHv3 5/5] nvme: Send uevent for some asynchronous events Keith Busch
2017-11-08 1:40 ` Guan Junxiong
2017-11-09 9:27 ` Christoph Hellwig
2017-11-09 16:18 ` Keith Busch [this message]
2017-11-09 16:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109161846.GE25017@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox