* [PATCH 1/2] nvmet: lower log level for each queue creation
@ 2017-12-04 8:47 Sagi Grimberg
2017-12-04 8:47 ` [PATCH 2/2] nvmet-rdma: lowering log level for chatty debug messages Sagi Grimberg
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sagi Grimberg @ 2017-12-04 8:47 UTC (permalink / raw)
Its a bit chatty to report on each queue, lets log
it only for debug purposes.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/target/fabrics-cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/fabrics-cmd.c b/drivers/nvme/target/fabrics-cmd.c
index 9e41904b0380..62315cc4b5b0 100644
--- a/drivers/nvme/target/fabrics-cmd.c
+++ b/drivers/nvme/target/fabrics-cmd.c
@@ -235,7 +235,7 @@ static void nvmet_execute_io_connect(struct nvmet_req *req)
goto out_ctrl_put;
}
- pr_info("adding queue %d to ctrl %d.\n", qid, ctrl->cntlid);
+ pr_debug("adding queue %d to ctrl %d.\n", qid, ctrl->cntlid);
out:
kfree(d);
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] nvmet-rdma: lowering log level for chatty debug messages
2017-12-04 8:47 [PATCH 1/2] nvmet: lower log level for each queue creation Sagi Grimberg
@ 2017-12-04 8:47 ` Sagi Grimberg
2017-12-04 8:51 ` Johannes Thumshirn
2017-12-04 8:50 ` [PATCH 1/2] nvmet: lower log level for each queue creation Johannes Thumshirn
2017-12-04 20:16 ` Christoph Hellwig
2 siblings, 1 reply; 5+ messages in thread
From: Sagi Grimberg @ 2017-12-04 8:47 UTC (permalink / raw)
Its a bit chatty to report on every deleted queue, so
keeping it dor debug purposes only.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/target/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 49912909c298..1d98aa125b6d 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -976,7 +976,7 @@ static void nvmet_rdma_destroy_queue_ib(struct nvmet_rdma_queue *queue)
static void nvmet_rdma_free_queue(struct nvmet_rdma_queue *queue)
{
- pr_info("freeing queue %d\n", queue->idx);
+ pr_debug("freeing queue %d\n", queue->idx);
nvmet_sq_destroy(&queue->nvme_sq);
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 1/2] nvmet: lower log level for each queue creation
2017-12-04 8:47 [PATCH 1/2] nvmet: lower log level for each queue creation Sagi Grimberg
2017-12-04 8:47 ` [PATCH 2/2] nvmet-rdma: lowering log level for chatty debug messages Sagi Grimberg
@ 2017-12-04 8:50 ` Johannes Thumshirn
2017-12-04 20:16 ` Christoph Hellwig
2 siblings, 0 replies; 5+ messages in thread
From: Johannes Thumshirn @ 2017-12-04 8:50 UTC (permalink / raw)
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] nvmet: lower log level for each queue creation
2017-12-04 8:47 [PATCH 1/2] nvmet: lower log level for each queue creation Sagi Grimberg
2017-12-04 8:47 ` [PATCH 2/2] nvmet-rdma: lowering log level for chatty debug messages Sagi Grimberg
2017-12-04 8:50 ` [PATCH 1/2] nvmet: lower log level for each queue creation Johannes Thumshirn
@ 2017-12-04 20:16 ` Christoph Hellwig
2 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2017-12-04 20:16 UTC (permalink / raw)
Thanks,
applied both patches to nvme-4.16.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-04 20:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-04 8:47 [PATCH 1/2] nvmet: lower log level for each queue creation Sagi Grimberg
2017-12-04 8:47 ` [PATCH 2/2] nvmet-rdma: lowering log level for chatty debug messages Sagi Grimberg
2017-12-04 8:51 ` Johannes Thumshirn
2017-12-04 8:50 ` [PATCH 1/2] nvmet: lower log level for each queue creation Johannes Thumshirn
2017-12-04 20:16 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox