* [PATCH] nvme: Setup streams after initializing namespace head
@ 2017-12-14 18:20 Keith Busch
2017-12-15 3:46 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: Keith Busch @ 2017-12-14 18:20 UTC (permalink / raw)
Fixes a NULL pointer dereference.
Reported-by: Arnav Dawn <a.dawn at samsung.com>
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 9831a592bbb9..15cb0b6bfe4f 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2870,7 +2870,6 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid)
blk_queue_logical_block_size(ns->queue, 1 << ns->lba_shift);
nvme_set_queue_limits(ctrl, ns->queue);
- nvme_setup_streams_ns(ctrl, ns);
id = nvme_identify_ns(ctrl, nsid);
if (!id)
@@ -2881,6 +2880,7 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid)
if (nvme_init_ns_head(ns, nsid, id, &new))
goto out_free_id;
+ nvme_setup_streams_ns(ctrl, ns);
#ifdef CONFIG_NVME_MULTIPATH
/*
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvme: Setup streams after initializing namespace head
2017-12-14 18:20 [PATCH] nvme: Setup streams after initializing namespace head Keith Busch
@ 2017-12-15 3:46 ` Martin K. Petersen
2017-12-15 14:14 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Martin K. Petersen @ 2017-12-15 3:46 UTC (permalink / raw)
Keith,
> Fixes a NULL pointer dereference.
Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvme: Setup streams after initializing namespace head
2017-12-15 3:46 ` Martin K. Petersen
@ 2017-12-15 14:14 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-12-15 14:14 UTC (permalink / raw)
Thanks, applied to nvme-4.15.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-15 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-14 18:20 [PATCH] nvme: Setup streams after initializing namespace head Keith Busch
2017-12-15 3:46 ` Martin K. Petersen
2017-12-15 14:14 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox