Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: Format fix when going from 4k sector size to 512 bytes
Date: Thu, 14 Dec 2017 15:42:57 -0700	[thread overview]
Message-ID: <20171214224257.GE26752@localhost.localdomain> (raw)
In-Reply-To: <20171214204936.17793-1-jeff.lien@wdc.com>

On Thu, Dec 14, 2017@02:49:36PM -0600, Jeff Lien wrote:
> If you format a device with a 4k sector size back to 512 bytes,
> the queue limit values for physical block size and IO sizes were
> not getting updated; only the logical block size was being
> updated.  This patch adds code to update the physical block
> and IO sizes.

That's true, though I always considered that to be a happy accident. As
far as I know, most NVMe SSDs advertising a 512 byte logical block are
only emulating that size, and are natively 4k or larger.

  reply	other threads:[~2017-12-14 22:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 20:49 [PATCH] NVMe: Format fix when going from 4k sector size to 512 bytes Jeff Lien
2017-12-14 22:42 ` Keith Busch [this message]
2017-12-15  3:52 ` Martin K. Petersen
2017-12-15 14:53   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214224257.GE26752@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox