From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] NVMe: Format fix when going from 4k sector size to 512 bytes
Date: Fri, 15 Dec 2017 06:53:23 -0800 [thread overview]
Message-ID: <20171215145323.GA16214@infradead.org> (raw)
In-Reply-To: <yq1fu8cmyvo.fsf@oracle.com>
On Thu, Dec 14, 2017@10:52:11PM -0500, Martin K. Petersen wrote:
>
> Jeff,
>
> > + blk_queue_logical_block_size(disk->queue, bs);
> > + blk_queue_physical_block_size(ns->queue, bs);
>
> A bit messy that you mix ns->queue and disk->queue.
It's not just ugly, but actually broken. We must use disk->queue
both times to correctly handle multipathing.
prev parent reply other threads:[~2017-12-15 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 20:49 [PATCH] NVMe: Format fix when going from 4k sector size to 512 bytes Jeff Lien
2017-12-14 22:42 ` Keith Busch
2017-12-15 3:52 ` Martin K. Petersen
2017-12-15 14:53 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215145323.GA16214@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox