Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 4.15-rc 1/3] nvme-core: Don't set nvme_wq as MEM_RECLAIM
Date: Thu, 21 Dec 2017 12:07:50 +0200	[thread overview]
Message-ID: <20171221100752.18386-2-sagi@grimberg.me> (raw)
In-Reply-To: <20171221100752.18386-1-sagi@grimberg.me>

From: Roy Shterman <roys@lightbitslabs.com>

nvme_wq is not a MEM_RECLAIM workqueue because it
can allocate memory in some of the works it is executing.

Signed-off-by: Roy Shterman <roys at lightbitslabs.com>
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index c33f848ab49d..221c97d57562 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3490,7 +3490,7 @@ int __init nvme_core_init(void)
 	int result;
 
 	nvme_wq = alloc_workqueue("nvme-wq",
-			WQ_UNBOUND | WQ_MEM_RECLAIM | WQ_SYSFS, 0);
+			WQ_UNBOUND | WQ_SYSFS, 0);
 	if (!nvme_wq)
 		return -ENOMEM;
 
-- 
2.14.1

  reply	other threads:[~2017-12-21 10:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 10:07 [PATCH 4.15-rc 0/3] few fabrics fixes targeted to 4.15 Sagi Grimberg
2017-12-21 10:07 ` Sagi Grimberg [this message]
2017-12-21 10:17   ` [PATCH 4.15-rc 1/3] nvme-core: Don't set nvme_wq as MEM_RECLAIM Christoph Hellwig
2017-12-21 10:41     ` Sagi Grimberg
2017-12-21 13:00       ` Christoph Hellwig
2017-12-21 13:17         ` Sagi Grimberg
2017-12-21 13:54           ` Christoph Hellwig
2017-12-21 14:17             ` Sagi Grimberg
2017-12-29  9:35               ` Christoph Hellwig
2017-12-31  9:51                 ` Sagi Grimberg
2017-12-21 10:07 ` [PATCH 4.15-rc 2/3] nvme-core/loop/rdma: Host delete_work and reset_work on system workqueues Sagi Grimberg
2017-12-21 10:25   ` Christoph Hellwig
2017-12-21 10:43     ` Sagi Grimberg
2017-12-21 13:00       ` Christoph Hellwig
2017-12-22 17:39   ` James Smart
2017-12-24  8:55     ` Sagi Grimberg
2017-12-21 10:07 ` [PATCH 4.15-rc 3/3] nvme-fabrics: Protect against module unload during create_ctrl Sagi Grimberg
2017-12-21 10:25   ` Christoph Hellwig
2017-12-21 18:31     ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171221100752.18386-2-sagi@grimberg.me \
    --to=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox