From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 4.15-rc 2/3] nvme-core/loop/rdma: Host delete_work and reset_work on system workqueues
Date: Thu, 21 Dec 2017 05:00:50 -0800 [thread overview]
Message-ID: <20171221130050.GB4239@infradead.org> (raw)
In-Reply-To: <a963929a-46af-c9b9-5bf4-e172ca2f6d59@grimberg.me>
On Thu, Dec 21, 2017@12:43:53PM +0200, Sagi Grimberg wrote:
> > I think we really need our own, separate WQ for this, e.g. a
> > nvme_reset_wq as reset progress under an swap / paging load is
> > essential and we need it isolated from the system.
>
> I agree, this was the thought when introducing nvme_wq.
>
> So you are fine with keeping controller delete in system_wq
> (or system_long_wq)?
I'd keep delete on the reset workqueue. If we can avoid depending
on too many system workqueues we're better off I think.
next prev parent reply other threads:[~2017-12-21 13:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 10:07 [PATCH 4.15-rc 0/3] few fabrics fixes targeted to 4.15 Sagi Grimberg
2017-12-21 10:07 ` [PATCH 4.15-rc 1/3] nvme-core: Don't set nvme_wq as MEM_RECLAIM Sagi Grimberg
2017-12-21 10:17 ` Christoph Hellwig
2017-12-21 10:41 ` Sagi Grimberg
2017-12-21 13:00 ` Christoph Hellwig
2017-12-21 13:17 ` Sagi Grimberg
2017-12-21 13:54 ` Christoph Hellwig
2017-12-21 14:17 ` Sagi Grimberg
2017-12-29 9:35 ` Christoph Hellwig
2017-12-31 9:51 ` Sagi Grimberg
2017-12-21 10:07 ` [PATCH 4.15-rc 2/3] nvme-core/loop/rdma: Host delete_work and reset_work on system workqueues Sagi Grimberg
2017-12-21 10:25 ` Christoph Hellwig
2017-12-21 10:43 ` Sagi Grimberg
2017-12-21 13:00 ` Christoph Hellwig [this message]
2017-12-22 17:39 ` James Smart
2017-12-24 8:55 ` Sagi Grimberg
2017-12-21 10:07 ` [PATCH 4.15-rc 3/3] nvme-fabrics: Protect against module unload during create_ctrl Sagi Grimberg
2017-12-21 10:25 ` Christoph Hellwig
2017-12-21 18:31 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221130050.GB4239@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox