Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 3/5] block: Provide blk_status_t decoding for retryable errors
Date: Thu,  4 Jan 2018 15:46:21 -0700	[thread overview]
Message-ID: <20180104224623.8944-4-keith.busch@intel.com> (raw)
In-Reply-To: <20180104224623.8944-1-keith.busch@intel.com>

This patch provides a common decoder for block status that may be retried
so various entities wishing to consult this do not have to duplicate
this decision.

Signed-off-by: Keith Busch <keith.busch at intel.com>
---
 include/linux/blk_types.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index a1e628e032da..b6a8723b493c 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -39,6 +39,22 @@ typedef u8 __bitwise blk_status_t;
 
 #define BLK_STS_AGAIN		((__force blk_status_t)12)
 
+static inline bool blk_retryable(blk_status_t error)
+{
+	switch (error) {
+	case BLK_STS_NOTSUPP:
+	case BLK_STS_NOSPC:
+	case BLK_STS_TARGET:
+	case BLK_STS_NEXUS:
+	case BLK_STS_MEDIUM:
+	case BLK_STS_PROTECTION:
+		return false;
+	}
+
+	/* Anything else could be a path failure, so should be retried */
+	return true;
+}
+
 struct blk_issue_stat {
 	u64 stat;
 };
-- 
2.13.6

  parent reply	other threads:[~2018-01-04 22:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-04 22:46 [PATCH 0/5] Failover criteria unification Keith Busch
2018-01-04 22:46 ` [PATCH 1/5] nvme: Add more command status translation Keith Busch
2018-01-04 23:41   ` Mike Snitzer
2018-01-08  8:39   ` Hannes Reinecke
2018-01-08  9:55   ` Christoph Hellwig
2018-01-08 10:09     ` Hannes Reinecke
2018-01-08 10:19       ` Christoph Hellwig
2018-01-08 15:29         ` Mike Snitzer
2018-01-08 15:34           ` Christoph Hellwig
2018-01-08 16:12             ` Keith Busch
2018-01-04 22:46 ` [PATCH 2/5] nvme/multipath: Consult blk_status_t for failover Keith Busch
2018-01-04 23:42   ` Mike Snitzer
2018-01-08  8:57   ` Hannes Reinecke
2018-01-08  9:57   ` Christoph Hellwig
2018-01-09 17:38     ` Keith Busch
2018-01-09 17:40       ` Christoph Hellwig
2018-01-04 22:46 ` Keith Busch [this message]
2018-01-04 23:43   ` [PATCH 3/5] block: Provide blk_status_t decoding for retryable errors Mike Snitzer
2018-01-08  8:58   ` Hannes Reinecke
2018-01-08  9:58   ` Christoph Hellwig
2018-01-04 22:46 ` [PATCH 4/5] nvme/multipath: Use blk_retryable Keith Busch
2018-01-04 23:44   ` Mike Snitzer
2018-01-08  8:58   ` Hannes Reinecke
2018-01-04 22:46 ` [PATCH 5/5] dm mpath: " Keith Busch
2018-01-04 23:45   ` Mike Snitzer
2018-01-08  8:59   ` Hannes Reinecke
2018-01-04 23:36 ` [PATCH 0/5] Failover criteria unification Mike Snitzer
2018-01-04 23:47   ` Keith Busch
2018-01-05  0:07     ` Mike Snitzer
2018-01-08  9:58     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180104224623.8944-4-keith.busch@intel.com \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox