Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hare@suse.com (Hannes Reinecke)
Subject: [PATCH 1/5] nvme: Add more command status translation
Date: Mon, 8 Jan 2018 11:09:03 +0100	[thread overview]
Message-ID: <2beb72a9-8502-fec8-8892-208cbb0967ac@suse.com> (raw)
In-Reply-To: <20180108095512.GC4673@lst.de>

On 01/08/2018 10:55 AM, Christoph Hellwig wrote:
> On Thu, Jan 04, 2018@03:46:19PM -0700, Keith Busch wrote:
>> This adds more NVMe status code translations to blk_status_t values,
>> and captures all the current status codes NVMe multipath uses.
>>
>> Signed-off-by: Keith Busch <keith.busch at intel.com>
>> ---
>>  drivers/nvme/host/core.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
>> index 2a69d735efbc..f1cf1f6c5b28 100644
>> --- a/drivers/nvme/host/core.c
>> +++ b/drivers/nvme/host/core.c
>> @@ -156,14 +156,20 @@ static blk_status_t nvme_error_status(struct request *req)
>>  	case NVME_SC_SUCCESS:
>>  		return BLK_STS_OK;
>>  	case NVME_SC_CAP_EXCEEDED:
>> +	case NVME_SC_LBA_RANGE:
>>  		return BLK_STS_NOSPC;
> 
> lba range isn't really enospc.  It is returned when the lba in
> the command is outside the logical size of the namespace.
> 
Isn't that distinction pretty academic?
The entire block-to-POSIX error mapping is pretty much ad-hoc anyway...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare at suse.com			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)

  reply	other threads:[~2018-01-08 10:09 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-04 22:46 [PATCH 0/5] Failover criteria unification Keith Busch
2018-01-04 22:46 ` [PATCH 1/5] nvme: Add more command status translation Keith Busch
2018-01-04 23:41   ` Mike Snitzer
2018-01-08  8:39   ` Hannes Reinecke
2018-01-08  9:55   ` Christoph Hellwig
2018-01-08 10:09     ` Hannes Reinecke [this message]
2018-01-08 10:19       ` Christoph Hellwig
2018-01-08 15:29         ` Mike Snitzer
2018-01-08 15:34           ` Christoph Hellwig
2018-01-08 16:12             ` Keith Busch
2018-01-04 22:46 ` [PATCH 2/5] nvme/multipath: Consult blk_status_t for failover Keith Busch
2018-01-04 23:42   ` Mike Snitzer
2018-01-08  8:57   ` Hannes Reinecke
2018-01-08  9:57   ` Christoph Hellwig
2018-01-09 17:38     ` Keith Busch
2018-01-09 17:40       ` Christoph Hellwig
2018-01-04 22:46 ` [PATCH 3/5] block: Provide blk_status_t decoding for retryable errors Keith Busch
2018-01-04 23:43   ` Mike Snitzer
2018-01-08  8:58   ` Hannes Reinecke
2018-01-08  9:58   ` Christoph Hellwig
2018-01-04 22:46 ` [PATCH 4/5] nvme/multipath: Use blk_retryable Keith Busch
2018-01-04 23:44   ` Mike Snitzer
2018-01-08  8:58   ` Hannes Reinecke
2018-01-04 22:46 ` [PATCH 5/5] dm mpath: " Keith Busch
2018-01-04 23:45   ` Mike Snitzer
2018-01-08  8:59   ` Hannes Reinecke
2018-01-04 23:36 ` [PATCH 0/5] Failover criteria unification Mike Snitzer
2018-01-04 23:47   ` Keith Busch
2018-01-05  0:07     ` Mike Snitzer
2018-01-08  9:58     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2beb72a9-8502-fec8-8892-208cbb0967ac@suse.com \
    --to=hare@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox