From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] nvme: pci: replace magic number with readable size macro in hmb code
Date: Sun, 14 Jan 2018 19:08:46 -0700 [thread overview]
Message-ID: <20180115020846.GD13580@localhost.localdomain> (raw)
In-Reply-To: <1515930040-20561-1-git-send-email-minwoo.im.dev@gmail.com>
On Sun, Jan 14, 2018@08:40:40PM +0900, Minwoo Im wrote:
> Those three identify fields(hmpre, hmmin, hmminds) have size in 4KB
> units.
>
> Replace magic numbers with human-readable size macro.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
Looks fine, though I thought an explicit #include <linux/sizes.h> is
in order since it's not obvious how we're pulling in these defines, but
there's already other SZ_* macro uses in this file, so it must be safe!
Reviewed-by: Keith Busch <keith.busch at intel.com>
next prev parent reply other threads:[~2018-01-15 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 11:40 [PATCH 1/2] nvme: pci: replace magic number with readable size macro in hmb code Minwoo Im
2018-01-15 2:08 ` Keith Busch [this message]
2018-01-17 12:58 ` Minwoo Im
2018-01-15 8:44 ` Christoph Hellwig
2018-01-17 13:00 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115020846.GD13580@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox