Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] nvme: pci: replace magic number with readable size macro in hmb code
Date: Mon, 15 Jan 2018 09:44:12 +0100	[thread overview]
Message-ID: <20180115084412.GB32313@lst.de> (raw)
In-Reply-To: <1515930040-20561-1-git-send-email-minwoo.im.dev@gmail.com>

SZ_4K does not add any value at all.  The SZ constants may make some
size in the megabyte and larger ranges where the multiples of 1024
aren't totally obviously, but they certainly don't for 4 digit values.

  parent reply	other threads:[~2018-01-15  8:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14 11:40 [PATCH 1/2] nvme: pci: replace magic number with readable size macro in hmb code Minwoo Im
2018-01-15  2:08 ` Keith Busch
2018-01-17 12:58   ` Minwoo Im
2018-01-15  8:44 ` Christoph Hellwig [this message]
2018-01-17 13:00   ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180115084412.GB32313@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox