From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/2] nvme: Don't use a stack buffer for keep-alive command
Date: Mon, 15 Jan 2018 09:42:40 +0100 [thread overview]
Message-ID: <20180115084240.GA32313@lst.de> (raw)
In-Reply-To: <76436c6a-5dee-b174-3b39-2735f8dc3a05@grimberg.me>
On Sun, Jan 14, 2018@11:31:40AM +0200, Sagi Grimberg wrote:
> Thanks Roland,
>
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
I think we'll need to fix this properly and embedd the struct nvme_command
into struct nvme_request. In the end any command could get an error
without DNR, and then we'd have a stale SQE on the stack.
next prev parent reply other threads:[~2018-01-15 8:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 21:38 [PATCH 2/2] nvme: Don't use a stack buffer for keep-alive command Roland Dreier
2018-01-14 9:31 ` Sagi Grimberg
2018-01-15 8:42 ` Christoph Hellwig [this message]
[not found] ` <CAG4TOxOtFqM-RAdS_r1hsPVuru_=abDtTUmB=XqGFaanBrqbEQ@mail.gmail.com>
2018-01-19 19:12 ` Christoph Hellwig
2018-02-08 15:59 ` Keith Busch
2018-02-08 16:02 ` Sagi Grimberg
2018-02-08 16:16 ` Keith Busch
2018-02-08 16:26 ` Keith Busch
2018-02-12 19:39 ` Sagi Grimberg
2018-02-12 20:07 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115084240.GA32313@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox