From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 2/2] nvme: Don't use a stack buffer for keep-alive command
Date: Mon, 12 Feb 2018 13:07:18 -0700 [thread overview]
Message-ID: <20180212200718.GB16923@localhost.localdomain> (raw)
In-Reply-To: <05381de6-81ae-cdec-ad46-47d348492996@grimberg.me>
On Mon, Feb 12, 2018@09:39:52PM +0200, Sagi Grimberg wrote:
> > > I'm fine with fixing this locally, btw isn't this exact same stale sqe
> > > happen in pci's nvme_delete_queue?
> >
> > Yeah, this is the other case. Fortunately that never gets called on a
> > quiesced admin queue, so we should be 'ok', but moving the command from
> > the stack into struct nvme_queue would be the right thing to do.
>
> So are you fine with picking Roland's patch to 4.16-rc?
I am okay with it. If we need to change this interface in the long term,
this is looks like an okay stop-gap until then.
> Christoph?
prev parent reply other threads:[~2018-02-12 20:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 21:38 [PATCH 2/2] nvme: Don't use a stack buffer for keep-alive command Roland Dreier
2018-01-14 9:31 ` Sagi Grimberg
2018-01-15 8:42 ` Christoph Hellwig
[not found] ` <CAG4TOxOtFqM-RAdS_r1hsPVuru_=abDtTUmB=XqGFaanBrqbEQ@mail.gmail.com>
2018-01-19 19:12 ` Christoph Hellwig
2018-02-08 15:59 ` Keith Busch
2018-02-08 16:02 ` Sagi Grimberg
2018-02-08 16:16 ` Keith Busch
2018-02-08 16:26 ` Keith Busch
2018-02-12 19:39 ` Sagi Grimberg
2018-02-12 20:07 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212200718.GB16923@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox