Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: jsmart2021@gmail.com (James Smart)
Subject: [PATCH 0/2] nvme-fc: io termination cleanup
Date: Tue,  6 Feb 2018 06:48:28 -0800	[thread overview]
Message-ID: <20180206144830.968-1-jsmart2021@gmail.com> (raw)

The patches address io termination issues in nvme-fc:

The first patch addresses a race condition on io termination vs
reset/delete abort paths that allowed an io to complete yet the
association termination counted it and is waiting for the completion.

The second patch addresses cleanup of the code that was synchronizing
io termination between the lldd done path and the blk-mq completion
path. the completion path existed because, at the time, the eh_handler
could return a successful return status, allowing the complete routine
to be called, although the io was still active in the lldd. Since then
the eh_handler has been corrected to reschedule the io timer after
initiating the abort and this condition is no longer true.

James Smart (2):
  nvme_fc: correct abort race condition on resets
  nvme_fc: cleanup io completion

 drivers/nvme/host/fc.c | 143 ++++++++++---------------------------------------
 1 file changed, 29 insertions(+), 114 deletions(-)

-- 
2.13.1

             reply	other threads:[~2018-02-06 14:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 14:48 James Smart [this message]
2018-02-06 14:48 ` [PATCH 1/2] nvme_fc: correct abort race condition on resets James Smart
2018-02-06 15:04   ` Johannes Thumshirn
2018-02-06 14:48 ` [PATCH 2/2] nvme_fc: cleanup io completion James Smart
2018-02-06 15:25   ` Johannes Thumshirn
2018-02-11  8:48 ` [PATCH 0/2] nvme-fc: io termination cleanup Sagi Grimberg
2018-02-12 16:28   ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180206144830.968-1-jsmart2021@gmail.com \
    --to=jsmart2021@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox