Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: james.smart@broadcom.com (James Smart)
Subject: [PATCH 0/2] nvme-fc: io termination cleanup
Date: Mon, 12 Feb 2018 08:28:25 -0800	[thread overview]
Message-ID: <d619aea1-d6fc-862a-b6b6-d35a1b6075d5@broadcom.com> (raw)
In-Reply-To: <a09e98ff-04d4-1cd9-3c6d-2a7c32e9f1b6@grimberg.me>

Looks good.? I was more interested in the blk-mq resource busy addition 
that was merged as well. it looks fine too, but I'll need to test it a bit.

Thanks

-- james


On 2/11/2018 12:48 AM, Sagi Grimberg wrote:
>
>> The patches address io termination issues in nvme-fc:
>>
>> The first patch addresses a race condition on io termination vs
>> reset/delete abort paths that allowed an io to complete yet the
>> association termination counted it and is waiting for the completion.
>>
>> The second patch addresses cleanup of the code that was synchronizing
>> io termination between the lldd done path and the blk-mq completion
>> path. the completion path existed because, at the time, the eh_handler
>> could return a successful return status, allowing the complete routine
>> to be called, although the io was still active in the lldd. Since then
>> the eh_handler has been corrected to reschedule the io timer after
>> initiating the abort and this condition is no longer true.
>
> Hi James,
>
> Picked up for 4.16-rc, had a slight conflict due to Max's ctrl state
> change. Please verify its ok.
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

      reply	other threads:[~2018-02-12 16:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 14:48 [PATCH 0/2] nvme-fc: io termination cleanup James Smart
2018-02-06 14:48 ` [PATCH 1/2] nvme_fc: correct abort race condition on resets James Smart
2018-02-06 15:04   ` Johannes Thumshirn
2018-02-06 14:48 ` [PATCH 2/2] nvme_fc: cleanup io completion James Smart
2018-02-06 15:25   ` Johannes Thumshirn
2018-02-11  8:48 ` [PATCH 0/2] nvme-fc: io termination cleanup Sagi Grimberg
2018-02-12 16:28   ` James Smart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d619aea1-d6fc-862a-b6b6-d35a1b6075d5@broadcom.com \
    --to=james.smart@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox