From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-pci: drain the entered requests after ctrl is shutdown
Date: Mon, 12 Feb 2018 12:15:19 -0700 [thread overview]
Message-ID: <20180212191519.GD16255@localhost.localdomain> (raw)
In-Reply-To: <b466996e-b00a-e848-25a0-e6ba768a573f@grimberg.me>
On Mon, Feb 12, 2018@08:43:58PM +0200, Sagi Grimberg wrote:
>
> > Currently, we will unquiesce the queues after the controller is
> > shutdown to avoid residual requests to be stuck. In fact, we can
> > do it more cleanly, just wait freeze and drain the queue in
> > nvme_dev_disable and finally leave the queues quiesced.
>
> Does this fix a bug? What is the benefit of leaving the queues
> quiesced in shutdown?
This doesn't appear to fix anything. The things this patch does do are
either unnecessary (quiece), or already done elsewhere (wait freeze).
next prev parent reply other threads:[~2018-02-12 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 12:57 [PATCH] nvme-pci: drain the entered requests after ctrl is shutdown Jianchao Wang
2018-02-12 18:43 ` Sagi Grimberg
2018-02-12 19:15 ` Keith Busch [this message]
2018-02-13 1:51 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212191519.GD16255@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox