From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH] nvme-pci: drain the entered requests after ctrl is shutdown
Date: Mon, 12 Feb 2018 20:43:58 +0200 [thread overview]
Message-ID: <b466996e-b00a-e848-25a0-e6ba768a573f@grimberg.me> (raw)
In-Reply-To: <1518440222-652-1-git-send-email-jianchao.w.wang@oracle.com>
> Currently, we will unquiesce the queues after the controller is
> shutdown to avoid residual requests to be stuck. In fact, we can
> do it more cleanly, just wait freeze and drain the queue in
> nvme_dev_disable and finally leave the queues quiesced.
Does this fix a bug? What is the benefit of leaving the queues
quiesced in shutdown?
next prev parent reply other threads:[~2018-02-12 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 12:57 [PATCH] nvme-pci: drain the entered requests after ctrl is shutdown Jianchao Wang
2018-02-12 18:43 ` Sagi Grimberg [this message]
2018-02-12 19:15 ` Keith Busch
2018-02-13 1:51 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b466996e-b00a-e848-25a0-e6ba768a573f@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox