Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] Revert "nvme: create 'slaves' and 'holders' entries for hidden controllers"
Date: Thu, 8 Mar 2018 15:45:58 -0700	[thread overview]
Message-ID: <20180308224558.GA14765@localhost.localdomain> (raw)
In-Reply-To: <20180307150344.GE30975@localhost.localdomain>

On Wed, Mar 07, 2018@08:03:45AM -0700, Keith Busch wrote:
> On Wed, Mar 07, 2018@02:40:39PM +0100, Hannes Reinecke wrote:
> > How do we detect the topology now?
> > Does nvme cli has the functionality?
> 
> Not in the way you'd probably like. It can provide all the information
> you'd need to put it together, but it doesn't provide a convenient
> method to get or visualize it. I'll add a note on the project to fix
> that.

Actually, nvmecli already has something kind of close, thanks
to Johannes! The 'list-subsys' command is most of the way there. It
currently looks like this, and just needs to go one level deeper to
append the namespaces to the output:

# nvme list-subsys -o json
{
  "Subsystems" : [
    {
      "Name" : "nvme-subsys0",
      "NQN" : "nqn.2014.08.org.nvmexpress:8086108ePHLE7200015N6P4B7335943:ICDPC5ED2ORA6.4T"
    },
    {
      "Paths" : [
        {
          "Name" : "nvme0",
          "Transport" : "pcie",
          "Address" : "0000:03:00.0"
        },
        {
          "Name" : "nvme1",
          "Transport" : "pcie",
          "Address" : "0000:04:00.0"
        }
      ]
    }
  ]
}

While this should readily work for fabrics, I needed to add a new kernel
driver patch to export the PCIe address for the above (patch staged
for 4.17).

  parent reply	other threads:[~2018-03-08 22:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 13:13 [PATCH] Revert "nvme: create 'slaves' and 'holders' entries for hidden controllers" Christoph Hellwig
2018-03-07 13:40 ` Hannes Reinecke
2018-03-07 15:03   ` Keith Busch
2018-03-07 15:56     ` Sitsofe Wheeler
2018-03-07 17:18       ` Christoph Hellwig
2018-03-07 17:38         ` Keith Busch
2018-03-07 17:47           ` Sitsofe Wheeler
2018-03-07 20:37             ` Keith Busch
2018-03-07 21:42               ` Sitsofe Wheeler
2018-03-08 17:14         ` Sagi Grimberg
2018-03-08 22:45     ` Keith Busch [this message]
2018-03-09  8:51 ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308224558.GA14765@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox