From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] fix failure when root filesystem is on nvme
Date: Sat, 21 Apr 2018 13:16:09 -0600 [thread overview]
Message-ID: <20180421191608.GC19048@localhost.localdomain> (raw)
In-Reply-To: <alpine.LRH.2.02.1804210942070.11467@file01.intranet.prod.int.rdu2.redhat.com>
On Sat, Apr 21, 2018@09:59:48AM -0400, Mikulas Patocka wrote:
> There's a bug in the nvme block device driver that causes failure when we
> have no initramfs and the root filesystem is directly on nvme. The driver
> spawns a work item nvme_reset_work() in the nvme_wq workqueue, but doesn't
> wait for it. The result is that the kernel attempts to mount the root
> filesystem before nvme_reset_work() finishes and it panics because it
> can't find the root device.
>
> It can be fixed with this simple patch (perhaps you can come up with a
> better patch that uses the asynchronous probing infrastructure?)
We probe asynchronously to fix other issues. First is that boot takes way
too long if you have a lot of devices when probing all of them serially,
and then certain init systems kill the probe task after a certain time,
breaking boot for those.
Is there something we can do for your setup to have the kernel wait for
the root partition to be available instead of givinig up after pci probe?
next prev parent reply other threads:[~2018-04-21 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 13:59 [PATCH] fix failure when root filesystem is on nvme Mikulas Patocka
2018-04-21 19:16 ` Keith Busch [this message]
2018-04-24 22:18 ` Mikulas Patocka
2018-04-24 23:14 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180421191608.GC19048@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox