Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: avoid hang on inaccessible paths
Date: Mon, 4 Jun 2018 14:56:44 +0200	[thread overview]
Message-ID: <20180604125644.GB30945@lst.de> (raw)
In-Reply-To: <db93e436-8f3b-352b-7395-f8eb7cf2e198@grimberg.me>

On Mon, Jun 04, 2018@03:17:43PM +0300, Sagi Grimberg wrote:
> From udev man:
>
> RUN{type}
>
> ...
>        This can only be used for very short-running foreground tasks.
>        Running an event process for a long period of time may block all
>        further events for this or a dependent device.
>
>        Starting daemons or other long running processes is not appropriate
>        for udev; the forked processes, detached or not, will be
>        unconditionally killed after the event handling has finished.
>
> One way around this is to disown the command from udev shell
> (e.g. $cmd & disown)

Oh well.  Offloading to a workqueue in the kernel to work around
this just doesn't really sound like the proper solution.  Then again
our connect really should not take longer than a reasonable timeout
anyway..

  reply	other threads:[~2018-06-04 12:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 11:16 [PATCH] nvme: avoid hang on inaccessible paths Hannes Reinecke
2018-05-30 12:12 ` Christoph Hellwig
2018-05-30 12:30   ` Hannes Reinecke
2018-05-30 12:54     ` Christoph Hellwig
2018-05-30 23:10       ` Sagi Grimberg
2018-06-04  6:24         ` Hannes Reinecke
2018-06-04  6:37           ` Christoph Hellwig
2018-06-04 12:17             ` Sagi Grimberg
2018-06-04 12:56               ` Christoph Hellwig [this message]
2018-06-06 19:02   ` Popuri, Sriram
2018-06-07  5:54     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180604125644.GB30945@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox