From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH] nvme: avoid hang on inaccessible paths
Date: Thu, 7 Jun 2018 07:54:41 +0200 [thread overview]
Message-ID: <20180607075441.638efcd6@pentland.suse.de> (raw)
In-Reply-To: <BN7PR06MB4033AEEF34ABC70C71175B6992650@BN7PR06MB4033.namprd06.prod.outlook.com>
On Wed, 6 Jun 2018 19:02:16 +0000
"Popuri, Sriram" <Sriram.Popuri@netapp.com> wrote:
> Looks like __nvme_find_path is pretty basic one.
> Let's say if there are 2 NVME_ANA_OPTIMIZED paths. However it looks
> like the first found path is chosen. That means having more than one
> NVME_ANA_OPTIMIZED paths doesn't help much. Any plans to round robin?
>
> > - /* XXX: try an inaccessible path as last resort per
> > 8.18.3.3 */
> > + if (!ns)
> > + ns = __nvme_find_path(head,
> > NVME_ANA_INACCESSIBLE);
>
> Also if there are multiple NVME_ANA_INACCESSIBLE paths and only a
> few(or one) is changing ANA state from INACCESSIBLE to OPTIMIZED and
> if that happens to be the last entry in your list, then trying above
> doesn't really help.
>
That patch has been retracted; I'll be sending an updated patch series
for implementing ANATT handling soon.
Cheers,
Hannes
prev parent reply other threads:[~2018-06-07 5:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 11:16 [PATCH] nvme: avoid hang on inaccessible paths Hannes Reinecke
2018-05-30 12:12 ` Christoph Hellwig
2018-05-30 12:30 ` Hannes Reinecke
2018-05-30 12:54 ` Christoph Hellwig
2018-05-30 23:10 ` Sagi Grimberg
2018-06-04 6:24 ` Hannes Reinecke
2018-06-04 6:37 ` Christoph Hellwig
2018-06-04 12:17 ` Sagi Grimberg
2018-06-04 12:56 ` Christoph Hellwig
2018-06-06 19:02 ` Popuri, Sriram
2018-06-07 5:54 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607075441.638efcd6@pentland.suse.de \
--to=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox