From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/6] nvme-pci: Remove unnecessary nested locking
Date: Wed, 6 Jun 2018 08:13:04 -0600 [thread overview]
Message-ID: <20180606141309.19389-2-keith.busch@intel.com> (raw)
In-Reply-To: <20180606141309.19389-1-keith.busch@intel.com>
The nvme pci driver no longer handles completions under the cq lock,
so the nested locking is not necesssary.
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/pci.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 4d0bb0e45401..d42a1c361162 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2003,13 +2003,7 @@ static void nvme_del_cq_end(struct request *req, blk_status_t error)
if (!error) {
unsigned long flags;
- /*
- * We might be called with the AQ cq_lock held
- * and the I/O queue cq_lock should always
- * nest inside the AQ one.
- */
- spin_lock_irqsave_nested(&nvmeq->cq_lock, flags,
- SINGLE_DEPTH_NESTING);
+ spin_lock_irqsave(&nvmeq->cq_lock, flags);
nvme_process_cq(nvmeq, &start, &end, -1);
spin_unlock_irqrestore(&nvmeq->cq_lock, flags);
--
2.14.3
next prev parent reply other threads:[~2018-06-06 14:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 14:13 [PATCH 0/6] minor nvme fixes for 4.18 Keith Busch
2018-06-06 14:13 ` Keith Busch [this message]
2018-06-06 14:19 ` [PATCH 1/6] nvme-pci: Remove unnecessary nested locking Jens Axboe
2018-06-07 7:16 ` Johannes Thumshirn
2018-06-07 8:43 ` Sagi Grimberg
2018-06-06 14:13 ` [PATCH 2/6] nvme-pci: Remove unnecessary completion doorbell check Keith Busch
2018-06-06 14:19 ` Jens Axboe
2018-06-07 7:16 ` Johannes Thumshirn
2018-06-07 8:44 ` Sagi Grimberg
2018-06-06 14:13 ` [PATCH 3/6] nvme-pci: Queue creation fixes Keith Busch
2018-06-06 14:59 ` Jens Axboe
2018-06-07 7:17 ` Johannes Thumshirn
2018-06-07 8:45 ` Sagi Grimberg
2018-06-06 14:13 ` [PATCH 4/6] nvme-pci: Remove HMB teardown on reset Keith Busch
2018-06-07 7:17 ` Johannes Thumshirn
2018-06-07 8:46 ` Sagi Grimberg
2018-06-07 14:27 ` Keith Busch
2018-06-06 14:13 ` [PATCH 5/6] nvme-pci: Unquiesce dead controller queues Keith Busch
2018-06-07 7:19 ` Johannes Thumshirn
2018-06-07 8:47 ` Sagi Grimberg
2018-06-06 14:13 ` [PATCH 6/6] nvme-pci: Make CMB SQ mod-param read-only Keith Busch
2018-06-07 7:19 ` Johannes Thumshirn
2018-06-07 14:29 ` Keith Busch
2018-06-07 8:48 ` Sagi Grimberg
2018-06-06 14:43 ` [PATCH 0/6] minor nvme fixes for 4.18 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606141309.19389-2-keith.busch@intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox