Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 4/6] nvme-pci: Remove HMB teardown on reset
Date: Wed,  6 Jun 2018 08:13:07 -0600	[thread overview]
Message-ID: <20180606141309.19389-5-keith.busch@intel.com> (raw)
In-Reply-To: <20180606141309.19389-1-keith.busch@intel.com>

The controller is required to disable its host memory buffer use on
controller reset. We don't need to submit an admin command to delete it,
so this patch skips sending that command so we don't need to worry about
handling a timeout.

Signed-off-by: Keith Busch <keith.busch at intel.com>
---
 drivers/nvme/host/pci.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index ed9fac721b8c..3a92eb8ffb36 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2215,14 +2215,6 @@ static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown)
 	nvme_stop_queues(&dev->ctrl);
 
 	if (!dead && dev->ctrl.queue_count > 0) {
-		/*
-		 * If the controller is still alive tell it to stop using the
-		 * host memory buffer.  In theory the shutdown / reset should
-		 * make sure that it doesn't access the host memoery anymore,
-		 * but I'd rather be safe than sorry..
-		 */
-		if (dev->host_mem_descs)
-			nvme_set_host_mem(dev, 0);
 		nvme_disable_io_queues(dev);
 		nvme_disable_admin_queue(dev, shutdown);
 	}
-- 
2.14.3

  parent reply	other threads:[~2018-06-06 14:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06 14:13 [PATCH 0/6] minor nvme fixes for 4.18 Keith Busch
2018-06-06 14:13 ` [PATCH 1/6] nvme-pci: Remove unnecessary nested locking Keith Busch
2018-06-06 14:19   ` Jens Axboe
2018-06-07  7:16   ` Johannes Thumshirn
2018-06-07  8:43   ` Sagi Grimberg
2018-06-06 14:13 ` [PATCH 2/6] nvme-pci: Remove unnecessary completion doorbell check Keith Busch
2018-06-06 14:19   ` Jens Axboe
2018-06-07  7:16   ` Johannes Thumshirn
2018-06-07  8:44   ` Sagi Grimberg
2018-06-06 14:13 ` [PATCH 3/6] nvme-pci: Queue creation fixes Keith Busch
2018-06-06 14:59   ` Jens Axboe
2018-06-07  7:17   ` Johannes Thumshirn
2018-06-07  8:45   ` Sagi Grimberg
2018-06-06 14:13 ` Keith Busch [this message]
2018-06-07  7:17   ` [PATCH 4/6] nvme-pci: Remove HMB teardown on reset Johannes Thumshirn
2018-06-07  8:46   ` Sagi Grimberg
2018-06-07 14:27     ` Keith Busch
2018-06-06 14:13 ` [PATCH 5/6] nvme-pci: Unquiesce dead controller queues Keith Busch
2018-06-07  7:19   ` Johannes Thumshirn
2018-06-07  8:47   ` Sagi Grimberg
2018-06-06 14:13 ` [PATCH 6/6] nvme-pci: Make CMB SQ mod-param read-only Keith Busch
2018-06-07  7:19   ` Johannes Thumshirn
2018-06-07 14:29     ` Keith Busch
2018-06-07  8:48   ` Sagi Grimberg
2018-06-06 14:43 ` [PATCH 0/6] minor nvme fixes for 4.18 Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180606141309.19389-5-keith.busch@intel.com \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox