Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/3] nvme: bio remapping tracepoint
Date: Thu, 7 Jun 2018 13:42:51 +0200	[thread overview]
Message-ID: <20180607114251.GA11119@lst.de> (raw)
In-Reply-To: <20180607133332.798a8bbc@pentland.suse.de>

On Thu, Jun 07, 2018@01:33:32PM +0200, Hannes Reinecke wrote:
> That would run afoul with device-mapper usage:
> 
> 	case DM_MAPIO_REMAPPED:
> 		/* the bio has been remapped so dispatch it */
> 		trace_block_bio_remap(clone->bi_disk->queue, clone,
> 				      bio_dev(io->orig_bio), sector);
> 		if (md->type == DM_TYPE_NVME_BIO_BASED)
> 			ret = direct_make_request(clone);
> 		else
> 			ret = generic_make_request(clone);
> 		break;
> 
> and we can't move the call into generic_make_request().
> So I fear it need to stay there.

Or you could move it from dm to where it belongs..

  reply	other threads:[~2018-06-07 11:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07  8:38 [PATCH 0/3] misc nvme fixes Hannes Reinecke
2018-06-07  8:38 ` [PATCH 1/3] nvme: also check for RESETTING state in nvmf_check_if_ready() Hannes Reinecke
2018-06-07  8:41   ` Sagi Grimberg
2018-06-07 11:26     ` Christoph Hellwig
2018-06-12 21:20       ` James Smart
2018-06-07  8:38 ` [PATCH 2/3] nvme: do not access request after calling blk_mq_end_request() Hannes Reinecke
2018-06-07  8:42   ` Sagi Grimberg
2018-06-07 11:27   ` Christoph Hellwig
2018-06-07  8:38 ` [PATCH 3/3] nvme: bio remapping tracepoint Hannes Reinecke
2018-06-07  8:41   ` Sagi Grimberg
2018-06-07 11:27   ` Christoph Hellwig
2018-06-07 11:33     ` Hannes Reinecke
2018-06-07 11:42       ` Christoph Hellwig [this message]
2018-06-07 16:21         ` Jens Axboe
2018-06-11 14:26           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607114251.GA11119@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox