From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/3] nvme: bio remapping tracepoint
Date: Mon, 11 Jun 2018 16:26:51 +0200 [thread overview]
Message-ID: <20180611142651.GA14160@lst.de> (raw)
In-Reply-To: <ef70773f-491c-274f-7273-f4f0d8b29470@kernel.dk>
On Thu, Jun 07, 2018@10:21:42AM -0600, Jens Axboe wrote:
> I was going to suggest that too, but there's really nothing
> in direct_make_request() that implies that it's necessarily
> a remap of an existing bio. The two current callers implies
> that, but that's really not a given.
I don't really think it makes much sense in a different context.
I've applied the patch for now, but I think this area could
use ?ome improvement.
prev parent reply other threads:[~2018-06-11 14:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 8:38 [PATCH 0/3] misc nvme fixes Hannes Reinecke
2018-06-07 8:38 ` [PATCH 1/3] nvme: also check for RESETTING state in nvmf_check_if_ready() Hannes Reinecke
2018-06-07 8:41 ` Sagi Grimberg
2018-06-07 11:26 ` Christoph Hellwig
2018-06-12 21:20 ` James Smart
2018-06-07 8:38 ` [PATCH 2/3] nvme: do not access request after calling blk_mq_end_request() Hannes Reinecke
2018-06-07 8:42 ` Sagi Grimberg
2018-06-07 11:27 ` Christoph Hellwig
2018-06-07 8:38 ` [PATCH 3/3] nvme: bio remapping tracepoint Hannes Reinecke
2018-06-07 8:41 ` Sagi Grimberg
2018-06-07 11:27 ` Christoph Hellwig
2018-06-07 11:33 ` Hannes Reinecke
2018-06-07 11:42 ` Christoph Hellwig
2018-06-07 16:21 ` Jens Axboe
2018-06-11 14:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611142651.GA14160@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox