Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH 2/4] nvmet: ANA transition timeout handling
Date: Thu, 7 Jun 2018 15:31:55 +0200	[thread overview]
Message-ID: <20180607153155.76452888@pentland.suse.de> (raw)
In-Reply-To: <20180607120745.GB11938@lst.de>

On Thu, 7 Jun 2018 14:07:46 +0200
Christoph Hellwig <hch@lst.de> wrote:

> On Thu, Jun 07, 2018@09:35:54AM +0200, Hannes Reinecke wrote:
> > Whenever an ANA state change is triggered the ANA state for that
> > group ID is set to 'state change' and a delayed work is started,
> > which will be setting the port to the actual state after anatt
> > has expired.  
> 
> What is the point?  We want to move to the actual state as soon as we
> can, where as soon is defined by a backend.  So we need manual control
> over exact states, including change state.
> 
> Even for testing it makes much more sense to have entirely manual
> control, so that your userspace test framework can trivial inject too
> long transition faults.
> 
But we would _require_ userspace interaction to facilitate correct
operation. And with a purely manual configuration on the target any
ANATT value becomes meaningless as we have no way of enforcing it.

And with that patch I don't need any userspace framework; just updating
the state is enough. And I even can set ANATT to 1 to have the state
update done directly.

Hannes

  reply	other threads:[~2018-06-07 13:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07  7:35 [PATCH 0/4] nvme: ANATT handling Hannes Reinecke
2018-06-07  7:35 ` [PATCH 1/4] nvmet: make ANATT configurable Hannes Reinecke
2018-06-07 12:06   ` Christoph Hellwig
2018-06-07 12:42     ` Hannes Reinecke
2018-06-07 13:03   ` Sagi Grimberg
2018-06-07  7:35 ` [PATCH 2/4] nvmet: ANA transition timeout handling Hannes Reinecke
2018-06-07 12:07   ` Christoph Hellwig
2018-06-07 13:31     ` Hannes Reinecke [this message]
2018-06-07 13:41       ` Christoph Hellwig
2018-06-07 13:12   ` Sagi Grimberg
2018-06-07  7:35 ` [PATCH 3/4] nvme: " Hannes Reinecke
2018-06-07 12:09   ` Christoph Hellwig
2018-06-07 12:52     ` Hannes Reinecke
2018-06-07 13:11       ` Christoph Hellwig
2018-06-07 13:16   ` Sagi Grimberg
2018-06-07 13:26     ` Christoph Hellwig
2018-06-07  7:35 ` [PATCH 4/4] nvme: start ANATT timer on out-of-order state changes Hannes Reinecke
2018-06-07 12:11   ` Christoph Hellwig
2018-06-07 12:37     ` Hannes Reinecke
2018-06-07 13:10       ` Christoph Hellwig
2018-06-07 13:20         ` Hannes Reinecke
2018-06-07 13:46           ` Christoph Hellwig
2018-06-07 14:01             ` Hannes Reinecke
2018-06-07 14:22               ` Christoph Hellwig
2018-06-07 15:20                 ` Sagi Grimberg
2018-06-07 13:20   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607153155.76452888@pentland.suse.de \
    --to=hare@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox