[PATCH 04/16] nvme-core: Complain if nvme_init_identify() fails

[keith.busch@intel.com (Keith Busch)]

On Mon, Oct 08, 2018@03:26:42PM -0700, Bart Van Assche wrote:
> On Mon, 2018-10-08@16:16 -0600, Keith Busch wrote:
> > On Mon, Oct 08, 2018@02:28:42PM -0700, Bart Van Assche wrote:
> > > This patch avoids that Coverity complains that some but not all callers of
> > > nvme_init_identify() check the return value of that function. See also
> > > Coverity ID 1423964.
> > 
> > That seems like an odd thing to complain about. If we required the
> > return value be checked, we have the "__must_check" attribute. In this
> > particular path, we don't care if nvme_init_identify returns an error,
> > and the failure is logged in kernel messages within the function already.
> > 
> > Is there another way to suppress the complaint?
> 
> One way is to change nvme_init_identify(ctrl) into the following:
> 
> if (nvme_init_identify(ctrl) < 0) {
> }
> 
> However, I'm not sure we should do that. Another possibility is to mark the
> complaint in the Coverity database as "intended". That means that the return
> value is ignored on purpose.

Right, I was hoping for a way to suppress the complaint without changing
the code since it is intended as-is.