Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH 7/7] blk-mq: use plug for devices that implement ->commits_rqs()
Date: Wed, 28 Nov 2018 06:35:38 -0700	[thread overview]
Message-ID: <20181128133538.20329-8-axboe@kernel.dk> (raw)
In-Reply-To: <20181128133538.20329-1-axboe@kernel.dk>

If we have that hook, we know the driver handles bd->last == true in
a smart fashion. If it does, even for multiple hardware queues, it's
a good idea to flush batches of requests to the device, if we have
batches of requests from the submitter.

Signed-off-by: Jens Axboe <axboe at kernel.dk>
---
 block/blk-mq.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 9e1045152e45..091557a43d53 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1945,7 +1945,12 @@ static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio)
 		/* bypass scheduler for flush rq */
 		blk_insert_flush(rq);
 		blk_mq_run_hw_queue(data.hctx, true);
-	} else if (plug && q->nr_hw_queues == 1) {
+	} else if (plug && (q->nr_hw_queues == 1 || q->mq_ops->commit_rqs)) {
+		/*
+		 * Use plugging if we have a ->commit_rqs() hook as well,
+		 * as we know the driver uses bd->last in a smart
+		 * fashion.
+		 */
 		unsigned int request_count = plug->rq_count;
 		struct request *last = NULL;
 
-- 
2.17.1

  parent reply	other threads:[~2018-11-28 13:35 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 13:35 [PATCHSET v2 0/8] block plugging improvements Jens Axboe
2018-11-28 13:35 ` [PATCH 1/7] block: improve logic around when to sort a plug list Jens Axboe
2018-11-29 15:44   ` Christoph Hellwig
2018-12-04  1:35   ` Sagi Grimberg
2018-11-28 13:35 ` [PATCH 2/7] blk-mq: add mq_ops->commit_rqs() Jens Axboe
2018-11-29 15:45   ` Christoph Hellwig
2018-11-29 16:52     ` Jens Axboe
2018-12-04  1:35   ` Sagi Grimberg
2018-11-28 13:35 ` [PATCH 3/7] nvme: implement mq_ops->commit_rqs() hook Jens Axboe
2018-11-29 15:47   ` Christoph Hellwig
2018-11-29 17:02     ` Jens Axboe
2018-11-29 17:04       ` Christoph Hellwig
2018-11-29 17:06         ` Jens Axboe
2018-11-29 17:38           ` Keith Busch
2018-11-29 17:42             ` Jens Axboe
2018-11-28 13:35 ` [PATCH 4/7] virtio_blk: " Jens Axboe
2018-12-04  1:36   ` Sagi Grimberg
2018-11-28 13:35 ` [PATCH 5/7] ataflop: " Jens Axboe
2018-11-29  7:03   ` Ming Lei
2018-11-29 15:47   ` Christoph Hellwig
2018-12-04  1:37   ` Sagi Grimberg
2018-11-28 13:35 ` [PATCH 6/7] blk-mq: use bd->last == true for list inserts Jens Axboe
2018-11-29  7:01   ` Ming Lei
2018-11-29 15:49   ` Christoph Hellwig
2018-12-04  1:39   ` Sagi Grimberg
2018-11-28 13:35 ` Jens Axboe [this message]
2018-11-29  7:13   ` [PATCH 7/7] blk-mq: use plug for devices that implement ->commits_rqs() Ming Lei
2018-11-29 15:49   ` Christoph Hellwig
2018-11-29 15:50     ` Christoph Hellwig
2018-11-29 17:05     ` Jens Axboe
2018-12-04  1:39   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128133538.20329-8-axboe@kernel.dk \
    --to=axboe@kernel.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox