Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH 2/7] blk-mq: add mq_ops->commit_rqs()
Date: Thu, 29 Nov 2018 09:52:51 -0700	[thread overview]
Message-ID: <d4ee9225-f26b-e460-a579-af518123ad72@kernel.dk> (raw)
In-Reply-To: <20181129154546.GB7234@infradead.org>

On 11/29/18 8:45 AM, Christoph Hellwig wrote:
> On Wed, Nov 28, 2018@06:35:33AM -0700, Jens Axboe wrote:
>> blk-mq passes information to the hardware about any given request being
>> the last that we will issue in this sequence. The point is that hardware
>> can defer costly doorbell type writes to the last request. But if we run
>> into errors issuing a sequence of requests, we may never send the request
>> with bd->last == true set. For that case, we need a hook that tells the
>> hardware that nothing else is coming right now.
>>
>> For failures returned by the drivers ->queue_rq() hook, the driver is
>> responsible for flushing pending requests, if it uses bd->last to
>> optimize that part. This works like before, no changes there.
>>
>> Reviewed-by: Omar Sandoval <osandov at fb.com>
>> Reviewed-by: Ming Lei <ming.lei at redhat.com>
>> Reviewed-by: Christoph Hellwig <hch at lst.de>
> 
> I don't think I actually reviewed it before in this form.
> 
> But now that I took a look it does indeed look fine to me:
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>

Only change is moving those two hunks from the later patch into this
one, so it isn't an empty declaration.

-- 
Jens Axboe

  reply	other threads:[~2018-11-29 16:52 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 13:35 [PATCHSET v2 0/8] block plugging improvements Jens Axboe
2018-11-28 13:35 ` [PATCH 1/7] block: improve logic around when to sort a plug list Jens Axboe
2018-11-29 15:44   ` Christoph Hellwig
2018-12-04  1:35   ` Sagi Grimberg
2018-11-28 13:35 ` [PATCH 2/7] blk-mq: add mq_ops->commit_rqs() Jens Axboe
2018-11-29 15:45   ` Christoph Hellwig
2018-11-29 16:52     ` Jens Axboe [this message]
2018-12-04  1:35   ` Sagi Grimberg
2018-11-28 13:35 ` [PATCH 3/7] nvme: implement mq_ops->commit_rqs() hook Jens Axboe
2018-11-29 15:47   ` Christoph Hellwig
2018-11-29 17:02     ` Jens Axboe
2018-11-29 17:04       ` Christoph Hellwig
2018-11-29 17:06         ` Jens Axboe
2018-11-29 17:38           ` Keith Busch
2018-11-29 17:42             ` Jens Axboe
2018-11-28 13:35 ` [PATCH 4/7] virtio_blk: " Jens Axboe
2018-12-04  1:36   ` Sagi Grimberg
2018-11-28 13:35 ` [PATCH 5/7] ataflop: " Jens Axboe
2018-11-29  7:03   ` Ming Lei
2018-11-29 15:47   ` Christoph Hellwig
2018-12-04  1:37   ` Sagi Grimberg
2018-11-28 13:35 ` [PATCH 6/7] blk-mq: use bd->last == true for list inserts Jens Axboe
2018-11-29  7:01   ` Ming Lei
2018-11-29 15:49   ` Christoph Hellwig
2018-12-04  1:39   ` Sagi Grimberg
2018-11-28 13:35 ` [PATCH 7/7] blk-mq: use plug for devices that implement ->commits_rqs() Jens Axboe
2018-11-29  7:13   ` Ming Lei
2018-11-29 15:49   ` Christoph Hellwig
2018-11-29 15:50     ` Christoph Hellwig
2018-11-29 17:05     ` Jens Axboe
2018-12-04  1:39   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4ee9225-f26b-e460-a579-af518123ad72@kernel.dk \
    --to=axboe@kernel.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox