* [PATCH] nvme-ioctl: clear rae for discovery log pages
@ 2018-12-07 22:05 Sagi Grimberg
2018-12-07 22:16 ` Keith Busch
2018-12-12 8:29 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Sagi Grimberg @ 2018-12-07 22:05 UTC (permalink / raw)
The discovery controller should now be able to send
us discovery log change events so we need to clear the
rae bit for that.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
nvme-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nvme-ioctl.c b/nvme-ioctl.c
index be0823dfbcc2..70a16ced925a 100644
--- a/nvme-ioctl.c
+++ b/nvme-ioctl.c
@@ -504,7 +504,7 @@ int nvme_effects_log(int fd, struct nvme_effects_log_page *effects_log)
int nvme_discovery_log(int fd, struct nvmf_disc_rsp_page_hdr *log, __u32 size)
{
- return nvme_get_log(fd, 0, NVME_LOG_DISC, true, size, log);
+ return nvme_get_log(fd, 0, NVME_LOG_DISC, false, size, log);
}
int nvme_sanitize_log(int fd, struct nvme_sanitize_log_page *sanitize_log)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] nvme-ioctl: clear rae for discovery log pages
2018-12-07 22:05 [PATCH] nvme-ioctl: clear rae for discovery log pages Sagi Grimberg
@ 2018-12-07 22:16 ` Keith Busch
2018-12-12 8:29 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Keith Busch @ 2018-12-07 22:16 UTC (permalink / raw)
On Fri, Dec 07, 2018@02:05:30PM -0800, Sagi Grimberg wrote:
> The discovery controller should now be able to send
> us discovery log change events so we need to clear the
> rae bit for that.
>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvme-ioctl: clear rae for discovery log pages
2018-12-07 22:05 [PATCH] nvme-ioctl: clear rae for discovery log pages Sagi Grimberg
2018-12-07 22:16 ` Keith Busch
@ 2018-12-12 8:29 ` Christoph Hellwig
2018-12-13 16:44 ` Sagi Grimberg
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2018-12-12 8:29 UTC (permalink / raw)
On Fri, Dec 07, 2018@02:05:30PM -0800, Sagi Grimberg wrote:
> The discovery controller should now be able to send
> us discovery log change events so we need to clear the
> rae bit for that.
Btw, I really think we need to clear the RAE bit in the kernel with
a small whitelist for those AENs that we pass on to userspace so that
we don't accidentally get the bit cleared. What do you think?
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvme-ioctl: clear rae for discovery log pages
2018-12-12 8:29 ` Christoph Hellwig
@ 2018-12-13 16:44 ` Sagi Grimberg
0 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2018-12-13 16:44 UTC (permalink / raw)
>> The discovery controller should now be able to send
>> us discovery log change events so we need to clear the
>> rae bit for that.
>
> Btw, I really think we need to clear the RAE bit in the kernel with
> a small whitelist for those AENs that we pass on to userspace so that
> we don't accidentally get the bit cleared. What do you think?
Makes sense...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-13 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-07 22:05 [PATCH] nvme-ioctl: clear rae for discovery log pages Sagi Grimberg
2018-12-07 22:16 ` Keith Busch
2018-12-12 8:29 ` Christoph Hellwig
2018-12-13 16:44 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox