From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/3] nvme-pci: refactor nvme_poll_irqdisable to make sparse happy
Date: Thu, 13 Dec 2018 09:51:07 +0100 [thread overview]
Message-ID: <20181213085107.17183-4-hch@lst.de> (raw)
In-Reply-To: <20181213085107.17183-1-hch@lst.de>
By duplicating the nvme_process_cq in both branches we keep the
sparse lock context checking happy, so do it.
Signed-off-by: Christoph Hellwig <hch at lst.de>
---
drivers/nvme/host/pci.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index fb9d8270f32c..c0f66d2f6e80 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1093,15 +1093,15 @@ static int nvme_poll_irqdisable(struct nvme_queue *nvmeq, unsigned int tag)
* using the CQ lock. For normal interrupt driven threads we have
* to disable the interrupt to avoid racing with it.
*/
- if (nvmeq->cq_vector == -1)
+ if (nvmeq->cq_vector == -1) {
spin_lock(&nvmeq->cq_poll_lock);
- else
- disable_irq(pci_irq_vector(pdev, nvmeq->cq_vector));
- found = nvme_process_cq(nvmeq, &start, &end, tag);
- if (nvmeq->cq_vector == -1)
+ found = nvme_process_cq(nvmeq, &start, &end, tag);
spin_unlock(&nvmeq->cq_poll_lock);
- else
+ } else {
+ disable_irq(pci_irq_vector(pdev, nvmeq->cq_vector));
+ found = nvme_process_cq(nvmeq, &start, &end, tag);
enable_irq(pci_irq_vector(pdev, nvmeq->cq_vector));
+ }
nvme_complete_cqes(nvmeq, start, end);
return found;
--
2.19.2
next prev parent reply other threads:[~2018-12-13 8:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 8:51 sparse fixes Christoph Hellwig
2018-12-13 8:51 ` [PATCH 1/3] nvmet-tcp: fix endianess annotations Christoph Hellwig
2018-12-13 16:42 ` Sagi Grimberg
2018-12-13 20:10 ` Christoph Hellwig
2018-12-16 16:24 ` Christoph Hellwig
2018-12-18 7:24 ` Sagi Grimberg
2018-12-13 8:51 ` [PATCH 2/3] " Christoph Hellwig
2018-12-13 16:42 ` Sagi Grimberg
2018-12-13 8:51 ` Christoph Hellwig [this message]
2018-12-13 16:43 ` [PATCH 3/3] nvme-pci: refactor nvme_poll_irqdisable to make sparse happy Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213085107.17183-4-hch@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox