From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/3] nvmet-tcp: fix endianess annotations
Date: Thu, 13 Dec 2018 21:10:38 +0100 [thread overview]
Message-ID: <20181213201038.GC15478@lst.de> (raw)
In-Reply-To: <631dd9ef-5ce6-27d4-8a4f-ca625cc816bb@grimberg.me>
On Thu, Dec 13, 2018@08:42:15AM -0800, Sagi Grimberg wrote:
>
>> @@ -776,7 +776,7 @@ static int nvmet_tcp_handle_icreq(struct nvmet_tcp_queue *queue)
>> icresp->hdr.pdo = 0;
>> icresp->hdr.plen = cpu_to_le32(icresp->hdr.hlen);
>> icresp->pfv = cpu_to_le16(NVME_TCP_PFV_1_0);
>> - icresp->maxdata = 0xffff; /* FIXME: support r2t */
>> + icresp->maxdata = cpu_to_le32(0xffff); /* FIXME: support r2t */
>> icresp->cpda = 0;
>> if (queue->hdr_digest)
>> icresp->digest |= NVME_TCP_HDR_DIGEST_ENABLE;
>
> This needs an actual fix, we need to send 0xffffffff as we don't have
> this any limitation..
Please either send a fix on top of this, or if you want separately
and I'll rebase.
next prev parent reply other threads:[~2018-12-13 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 8:51 sparse fixes Christoph Hellwig
2018-12-13 8:51 ` [PATCH 1/3] nvmet-tcp: fix endianess annotations Christoph Hellwig
2018-12-13 16:42 ` Sagi Grimberg
2018-12-13 20:10 ` Christoph Hellwig [this message]
2018-12-16 16:24 ` Christoph Hellwig
2018-12-18 7:24 ` Sagi Grimberg
2018-12-13 8:51 ` [PATCH 2/3] " Christoph Hellwig
2018-12-13 16:42 ` Sagi Grimberg
2018-12-13 8:51 ` [PATCH 3/3] nvme-pci: refactor nvme_poll_irqdisable to make sparse happy Christoph Hellwig
2018-12-13 16:43 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213201038.GC15478@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox