From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-multipath: drop optimization for static ANA group IDs
Date: Mon, 21 Jan 2019 14:50:25 +0100 [thread overview]
Message-ID: <20190121135025.GB25858@lst.de> (raw)
In-Reply-To: <e0416085-b02f-3578-c3aa-02296b040aef@grimberg.me>
On Mon, Jan 21, 2019@01:23:39AM -0800, Sagi Grimberg wrote:
>
>> Ok, based on the version that actually keeps the optimization I
>> have to say I actually prefer this variant, given that it is a lot
>> less code and special cases. Sorry for sending you off the wrong track.
>>
>> Reviewed-by: Christoph Hellwig <hch at lst.de>
>
> Oh, so this ends up preferred over v2... I don't have any problem
> with allocating for the worse case here...
>
> Doesn't look like this is urgent for 5.0 rc, shall we queue it
> for 5.1?
Without it we use unallocate memory if the controller sets bit 6
in anacap. So yes, I think it should go into 5.0 and -stable.
next prev parent reply other threads:[~2019-01-21 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 8:45 [PATCH] nvme-multipath: drop optimization for static ANA group IDs Hannes Reinecke
2019-01-09 18:43 ` Christoph Hellwig
2019-01-15 5:51 ` Christoph Hellwig
2019-01-19 13:19 ` Christoph Hellwig
2019-01-21 9:23 ` Sagi Grimberg
2019-01-21 13:50 ` Christoph Hellwig [this message]
2019-01-21 17:50 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121135025.GB25858@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox