* [PATCH] nvme/trace: Fix cdw10 buffer overrun
@ 2019-03-06 22:03 Keith Busch
2019-03-07 1:32 ` Sagi Grimberg
2019-03-08 13:43 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Keith Busch @ 2019-03-06 22:03 UTC (permalink / raw)
The field is defined to be a 24 byte array, we don't need to multiply
the sizeof() that field by the number of dwords it covers.
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/trace.h b/drivers/nvme/host/trace.h
index 244d7c177e5a..97d3c77365b8 100644
--- a/drivers/nvme/host/trace.h
+++ b/drivers/nvme/host/trace.h
@@ -108,7 +108,7 @@ TRACE_EVENT(nvme_setup_cmd,
__entry->metadata = le64_to_cpu(cmd->common.metadata);
__assign_disk_name(__entry->disk, req->rq_disk);
memcpy(__entry->cdw10, &cmd->common.cdw10,
- 6 * sizeof(__entry->cdw10));
+ sizeof(__entry->cdw10));
),
TP_printk("nvme%d: %sqid=%d, cmdid=%u, nsid=%u, flags=0x%x, meta=0x%llx, cmd=(%s %s)",
__entry->ctrl_id, __print_disk_name(__entry->disk),
--
2.14.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvme/trace: Fix cdw10 buffer overrun
2019-03-06 22:03 [PATCH] nvme/trace: Fix cdw10 buffer overrun Keith Busch
@ 2019-03-07 1:32 ` Sagi Grimberg
2019-03-08 13:43 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2019-03-07 1:32 UTC (permalink / raw)
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvme/trace: Fix cdw10 buffer overrun
2019-03-06 22:03 [PATCH] nvme/trace: Fix cdw10 buffer overrun Keith Busch
2019-03-07 1:32 ` Sagi Grimberg
@ 2019-03-08 13:43 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2019-03-08 13:43 UTC (permalink / raw)
Thanks,
applied to nvme-5.1.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-08 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-06 22:03 [PATCH] nvme/trace: Fix cdw10 buffer overrun Keith Busch
2019-03-07 1:32 ` Sagi Grimberg
2019-03-08 13:43 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox