From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-multipath: avoid crash on invalid subsystem cntlid enumeration
Date: Fri, 29 Mar 2019 11:02:44 +0100 [thread overview]
Message-ID: <20190329100244.GA28689@lst.de> (raw)
In-Reply-To: <20190329095754.109653-1-hare@suse.de>
On Fri, Mar 29, 2019@10:57:54AM +0100, Hannes Reinecke wrote:
> The controller ID is supposed to be unique for each subsystem;
> however, if it _isn't_ we will crash when calling device_add_disk()
> for the namespaces.
> While this surely is an error on the subsystem side we really shouldn't
> crash. So simply use the 'instance' number when generating the disk
> name to avoid this issue.
I agree that we should not crash in that, but I'd rather print an
error message and reject using that controller with the duplicate
controller id than hacking around the issue.
next prev parent reply other threads:[~2019-03-29 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 9:57 [PATCH] nvme-multipath: avoid crash on invalid subsystem cntlid enumeration Hannes Reinecke
2019-03-29 10:02 ` Christoph Hellwig [this message]
2019-03-29 10:23 ` Hannes Reinecke
2019-04-01 5:17 ` Keith Busch
2019-04-01 11:50 ` Hannes Reinecke
2019-04-02 8:55 ` Keith Busch
2019-04-03 18:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329100244.GA28689@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox