From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-multipath: avoid crash on invalid subsystem cntlid enumeration
Date: Wed, 3 Apr 2019 20:09:58 +0200 [thread overview]
Message-ID: <20190403180958.GE28682@lst.de> (raw)
In-Reply-To: <20190402085540.GE16792@localhost.localdomain>
On Tue, Apr 02, 2019@02:55:40AM -0600, Keith Busch wrote:
> On Mon, Apr 01, 2019@04:50:13AM -0700, Hannes Reinecke wrote:
> > On 4/1/19 7:17 AM, Keith Busch wrote:
> > > We might want to use this patch anyway. It is possible some process
> > > reference count is preventing the final release when we want to remove
> > > a controller, and a subsequent discover, even if the cntlid is unqiue,
> > > would create a duplicate disk name.
> > >
> > I don't mind which patch is taken.
> > But crashing on misbehaving targets is never a good idea.
>
> I 100% agree. :)
>
> > Do I need to send the other patch?
>
> Can we do both? I like the warning when an invalid subsystem is detected,
> but your original patch fixes the unique gendisk name, so I'd vote
> to keep that good code, but justify it with a slightly different
> changelog. Something along the following:
Yes, let's do both. Hannes, please resend a series with this patch
with the updated changelog and the duplicate cntlid check one.
prev parent reply other threads:[~2019-04-03 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 9:57 [PATCH] nvme-multipath: avoid crash on invalid subsystem cntlid enumeration Hannes Reinecke
2019-03-29 10:02 ` Christoph Hellwig
2019-03-29 10:23 ` Hannes Reinecke
2019-04-01 5:17 ` Keith Busch
2019-04-01 11:50 ` Hannes Reinecke
2019-04-02 8:55 ` Keith Busch
2019-04-03 18:09 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403180958.GE28682@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox