From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 1/2] nvme: nvme_set_queue_count should use descriptive macros
Date: Tue, 30 Apr 2019 08:23:59 -0700 [thread overview]
Message-ID: <20190430152359.GA11751@infradead.org> (raw)
In-Reply-To: <20190429173533.10366-2-ednadols@linux.microsoft.com>
On Mon, Apr 29, 2019@10:35:32AM -0700, Edmund Nadolski wrote:
> Implement macros to set/get the number of submission and/or completion
> queues requested by the Set Features command. This replaces the bit
> masking/shifting code which is harder to read and more error prone to
> maintain.
>
> Signed-off-by: Edmund Nadolski <ednadols at linux.microsoft.com>
I have to say I actually find this much harder to read than the old
version.
next prev parent reply other threads:[~2019-04-30 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 17:35 [PATCH 0/2] nvme: some cleanup Edmund Nadolski
2019-04-29 17:35 ` [PATCH 1/2] nvme: nvme_set_queue_count should use descriptive macros Edmund Nadolski
2019-04-29 23:21 ` Sagi Grimberg
2019-04-30 15:23 ` Christoph Hellwig [this message]
2019-04-29 17:35 ` [PATCH 2/2] nvme: add clarifying comments and fix some typos Edmund Nadolski
2019-04-29 23:23 ` Sagi Grimberg
2019-04-30 4:46 ` Edmund Nadolski
2019-04-29 23:32 ` Minwoo Im
2019-04-30 3:22 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430152359.GA11751@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox