From: ednadols@linux.microsoft.com (Edmund Nadolski)
Subject: [PATCH 2/2] nvme: add clarifying comments and fix some typos
Date: Mon, 29 Apr 2019 21:46:13 -0700 [thread overview]
Message-ID: <6a984000-0b1c-d091-6d92-28fa44b9c475@linux.microsoft.com> (raw)
In-Reply-To: <ac3905e6-208b-a528-f1ff-189c2f8048f8@grimberg.me>
On 4/29/19 4:23 PM, Sagi Grimberg wrote:
>
>> Add comment descriptions for struct fields per NVMe spec.
>
> Lets split typos from this patch. Not sure that the comments are all
> that useful, as we usually have a spec/tp at hand...
They could be useful to save a lookup (or when a spec isn't handy). I had
also thought of doing the nvm_id_ctrl and nvme_id_ns structs, but I'll hold
off as it seems folks see this as extraneous.
I will split out the typos out and re-send.
Thanks,
Ed
next prev parent reply other threads:[~2019-04-30 4:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 17:35 [PATCH 0/2] nvme: some cleanup Edmund Nadolski
2019-04-29 17:35 ` [PATCH 1/2] nvme: nvme_set_queue_count should use descriptive macros Edmund Nadolski
2019-04-29 23:21 ` Sagi Grimberg
2019-04-30 15:23 ` Christoph Hellwig
2019-04-29 17:35 ` [PATCH 2/2] nvme: add clarifying comments and fix some typos Edmund Nadolski
2019-04-29 23:23 ` Sagi Grimberg
2019-04-30 4:46 ` Edmund Nadolski [this message]
2019-04-29 23:32 ` Minwoo Im
2019-04-30 3:22 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a984000-0b1c-d091-6d92-28fa44b9c475@linux.microsoft.com \
--to=ednadols@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox