Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH 0/3] nvme-core: add user command filter
Date: Fri, 10 May 2019 15:42:56 -0600	[thread overview]
Message-ID: <20190510214255.GA11723@localhost.localdomain> (raw)
In-Reply-To: <20190508183634.4682-1-chaitanya.kulkarni@wdc.com>

On Wed, May 08, 2019@11:36:31AM -0700, Chaitanya Kulkarni wrote:
> This patch-series adds a filter to allow only certain user commands.                                   
> Right now we use this infrastructure to prevent the user get log page
> commands where RAE bit is cleared. We only allow get log pages to be
> read with RAE == 0 where we issue the uevent to the userspace so that
> user can clear the log pages.
> 
> Here we white list the log pages which are only allowed when RAE == 0.
> We also allow Vendor Specific log pages irrespective of the RAE.

I'm generally against the passthrough interface examining commands. It
is not for the driver to decide what an admin can't send to their devices.

  parent reply	other threads:[~2019-05-10 21:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 18:36 [PATCH 0/3] nvme-core: add user command filter Chaitanya Kulkarni
2019-05-08 18:36 ` [PATCH 1/3] nvme: introduce and use RAE bit macro Chaitanya Kulkarni
2019-05-08 18:36 ` [PATCH 2/3] nvme: add sanitize log identifier Chaitanya Kulkarni
2019-05-08 18:36 ` [PATCH 3/3] nvme-core: add filter for user commands Chaitanya Kulkarni
2019-05-10 18:05 ` [PATCH 0/3] nvme-core: add user command filter Chaitanya Kulkarni
2019-05-10 21:42 ` Keith Busch [this message]
2019-05-13 13:25   ` Christoph Hellwig
2019-05-13 16:49     ` Keith Busch
2019-05-13 20:36       ` Chaitanya Kulkarni
2019-05-13 20:52         ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190510214255.GA11723@localhost.localdomain \
    --to=kbusch@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox