Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH 0/3] nvme-core: add user command filter
Date: Mon, 13 May 2019 14:52:54 -0600	[thread overview]
Message-ID: <20190513205254.GA18823@localhost.localdomain> (raw)
In-Reply-To: <SN6PR04MB4527DBCEE5CD5A54965EA0C4860F0@SN6PR04MB4527.namprd04.prod.outlook.com>

On Mon, May 13, 2019@08:36:32PM +0000, Chaitanya Kulkarni wrote:
> I agree that passthru means we should just passthru. But user-pace
> doesn't have the access to take
> 
> corrective action on clearing the AEN.
> 
> The cases where Kernel is responsible for reading and clearing out the
> log pages/AENs
> 
> if we allow userspace to clear those it will create a problem in the
> kernel code if kernel code
> 
> expects the aen bit to be set. This can lead to complex bugs where,
> 
> 1. Kernel expects the log page and aen to be present.
> 
> 2. But it is been cleared since userspace read it but did not take the
> corrective action or doesn't have the
> 
>     right interface to take corrective action so it depends on a kernel
> (driver) to take the corrective action.

But the kernel still sees the AEN, and the log the kernel wants to read
will still exist. None of the logs contents are latched to RAE, so I'm
afraid I'm not seeing what problem letting user space re-arm the AEN
creates. Could you walk me through a scenario that triggers such a bug?

      reply	other threads:[~2019-05-13 20:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 18:36 [PATCH 0/3] nvme-core: add user command filter Chaitanya Kulkarni
2019-05-08 18:36 ` [PATCH 1/3] nvme: introduce and use RAE bit macro Chaitanya Kulkarni
2019-05-08 18:36 ` [PATCH 2/3] nvme: add sanitize log identifier Chaitanya Kulkarni
2019-05-08 18:36 ` [PATCH 3/3] nvme-core: add filter for user commands Chaitanya Kulkarni
2019-05-10 18:05 ` [PATCH 0/3] nvme-core: add user command filter Chaitanya Kulkarni
2019-05-10 21:42 ` Keith Busch
2019-05-13 13:25   ` Christoph Hellwig
2019-05-13 16:49     ` Keith Busch
2019-05-13 20:36       ` Chaitanya Kulkarni
2019-05-13 20:52         ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190513205254.GA18823@localhost.localdomain \
    --to=kbusch@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox