Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH RFC] nvme: Common subsys and controller instances IDA
Date: Thu, 16 May 2019 08:46:51 +0200	[thread overview]
Message-ID: <20190516064651.GA30234@lst.de> (raw)
In-Reply-To: <20190515213351.22190-1-keith.busch@intel.com>

On Wed, May 15, 2019@03:33:51PM -0600, Keith Busch wrote:
> So here's a solution that no one will like: pull subsystem and controller
> instances from the same IDA so that there won't be any namespace block
> devices with a matching controller handle name. While this does nothing
> to clear up device relationships, this will force the user to think
> really hard about what they're doing and avoid such mistakes.

Hmm.  So we'll get:

/dev/nvme0
 - chardev subsys X ctl 1

/dev/nvme1n1
/dev/nvme1n2
 - namespaces for subsys X

/dev/nvme2
 - chardev subsys X ctl 2

/dev/nvme3
 - chardev subsys Y ctl 1

...

This should work.  Not sure it really buys us so much, though.

Btw, I wonder if we should have udev rules for:

/dev/nvme-subsys-$NQN-ctrl1
/dev/nvme-subsys-$NQN-ctrl2
/dev/nvme-subsys-$NQN-ns1
/dev/nvme-subsys-$NQN-ns2

I have to admit that since udev/systemd moved to github I can't
be bother to send them patches, though as it would require signing
up for that crappy service.

  reply	other threads:[~2019-05-16  6:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 21:33 [PATCH RFC] nvme: Common subsys and controller instances IDA Keith Busch
2019-05-16  6:46 ` Christoph Hellwig [this message]
2019-05-16  7:03   ` Hannes Reinecke
2019-05-16 14:44     ` Keith Busch
2019-05-16 14:51       ` Christoph Hellwig
2019-05-16 14:58       ` Martin K. Petersen
2019-05-21  9:54         ` Max Gurtovoy
2019-05-21 14:35           ` Keith Busch
2019-05-21 14:51             ` Max Gurtovoy
2019-05-21 14:58               ` Keith Busch
2019-05-24  8:03             ` Sagi Grimberg
2019-05-24 14:07               ` Keith Busch
2019-05-24 16:17                 ` Sagi Grimberg
2019-05-24 19:14                   ` Max Gurtovoy
2019-05-24 23:23                     ` Sagi Grimberg
2019-05-24 23:30                       ` Keith Busch
2019-05-16 14:40   ` Keith Busch
2019-05-16 14:57     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190516064651.GA30234@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox