Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH RFC] nvme: Common subsys and controller instances IDA
Date: Tue, 21 May 2019 08:58:40 -0600	[thread overview]
Message-ID: <20190521145840.GC1639@localhost.localdomain> (raw)
In-Reply-To: <55f15756-0385-f9c4-a916-079a6b12a5c1@mellanox.com>

On Tue, May 21, 2019@05:51:25PM +0300, Max Gurtovoy wrote:
> 
> On 5/21/2019 5:35 PM, Keith Busch wrote:
> > On Tue, May 21, 2019@02:54:53AM -0700, Max Gurtovoy wrote:
> > > maybe we can improve it and print also the namespace during the "nvme
> > > list-subsys" command.
> > > 
> > > something like:
> > > 
> > > [root at server50 ~]# nvme list-subsys
> > > nvme-subsys0 - NQN=testsubsystem_0
> > > \
> > >   ?+- nvme0 rdma traddr=11.212.140.146 trsvcid=4420
> > >   ?\
> > >   ? +- nvme0n1 SN=cf8bbff661502c51 Model=Linux
> > >   ? +- nvme0n2 SN=cf8bbff661502c51 Model=Linux
> > > 
> > > 
> > > and we'll get subsys/ctrl/ns relations in 1 cmd.
> > > 
> > > thoughts ?
> > Yes, this is very useful! I'd like to add this as soon as possible.
> > Do you have a patch, or is this just an example?  The only change I'd
> > recommend is remove SN and Model since those are controller properties
> > rather than from the namespace.
> 
> This is just an example but I can prepare something in a couple of days.
> 
> Let me know what do you prefer (and which attrs to print there)

Let's just get the namespace handles (ex nvme0n1) displaying with each
of their controllers within a subsystem. Showing just this relationship
will be immediately helpful. We can can add verbose flags to get more
details in the future.

  reply	other threads:[~2019-05-21 14:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 21:33 [PATCH RFC] nvme: Common subsys and controller instances IDA Keith Busch
2019-05-16  6:46 ` Christoph Hellwig
2019-05-16  7:03   ` Hannes Reinecke
2019-05-16 14:44     ` Keith Busch
2019-05-16 14:51       ` Christoph Hellwig
2019-05-16 14:58       ` Martin K. Petersen
2019-05-21  9:54         ` Max Gurtovoy
2019-05-21 14:35           ` Keith Busch
2019-05-21 14:51             ` Max Gurtovoy
2019-05-21 14:58               ` Keith Busch [this message]
2019-05-24  8:03             ` Sagi Grimberg
2019-05-24 14:07               ` Keith Busch
2019-05-24 16:17                 ` Sagi Grimberg
2019-05-24 19:14                   ` Max Gurtovoy
2019-05-24 23:23                     ` Sagi Grimberg
2019-05-24 23:30                       ` Keith Busch
2019-05-16 14:40   ` Keith Busch
2019-05-16 14:57     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521145840.GC1639@localhost.localdomain \
    --to=kbusch@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox