* [PATCH] nvme: Fix known effects
2019-05-17 16:13 ` [PATCH] nvme: Fix known effects Keith Busch
@ 2019-05-17 17:28 ` Edmund Nadolski
2019-05-17 17:32 ` Chaitanya Kulkarni
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Edmund Nadolski @ 2019-05-17 17:28 UTC (permalink / raw)
On 5/17/19 9:13 AM, Keith Busch wrote:
> We're trying to append known effects to the ones reported in the
> controller's log. The original patch accomplished this, but something
> went wrong when patch was merged causing the effects log to override
> the known effects.
>
> Link: http://lists.infradead.org/pipermail/linux-nvme/2019-May/023710.html
> Cc: Maxim Levitsky <mlevitsk at redhat.com>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index f2411d50e764..5175451916d1 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1273,9 +1273,9 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> return 0;
> }
>
> - effects |= nvme_known_admin_effects(opcode);
> if (ctrl->effects)
> effects = le32_to_cpu(ctrl->effects->acs[opcode]);
> + effects |= nvme_known_admin_effects(opcode);
>
> /*
> * For simplicity, IO to all namespaces is quiesced even if the command
>
LGTM
Ed
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] nvme: Fix known effects
2019-05-17 16:13 ` [PATCH] nvme: Fix known effects Keith Busch
2019-05-17 17:28 ` Edmund Nadolski
@ 2019-05-17 17:32 ` Chaitanya Kulkarni
2019-05-21 6:49 ` Christoph Hellwig
2019-05-21 7:26 ` Minwoo Im
3 siblings, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2019-05-17 17:32 UTC (permalink / raw)
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
On 5/17/19 9:19 AM, Keith Busch wrote:
> We're trying to append known effects to the ones reported in the
> controller's log. The original patch accomplished this, but something
> went wrong when patch was merged causing the effects log to override
> the known effects.
>
> Link: http://lists.infradead.org/pipermail/linux-nvme/2019-May/023710.html
> Cc: Maxim Levitsky <mlevitsk at redhat.com>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index f2411d50e764..5175451916d1 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1273,9 +1273,9 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> return 0;
> }
>
> - effects |= nvme_known_admin_effects(opcode);
> if (ctrl->effects)
> effects = le32_to_cpu(ctrl->effects->acs[opcode]);
> + effects |= nvme_known_admin_effects(opcode);
>
> /*
> * For simplicity, IO to all namespaces is quiesced even if the command
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] nvme: Fix known effects
2019-05-17 16:13 ` [PATCH] nvme: Fix known effects Keith Busch
2019-05-17 17:28 ` Edmund Nadolski
2019-05-17 17:32 ` Chaitanya Kulkarni
@ 2019-05-21 6:49 ` Christoph Hellwig
2019-05-21 7:26 ` Minwoo Im
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2019-05-21 6:49 UTC (permalink / raw)
Looks good,
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] nvme: Fix known effects
2019-05-17 16:13 ` [PATCH] nvme: Fix known effects Keith Busch
` (2 preceding siblings ...)
2019-05-21 6:49 ` Christoph Hellwig
@ 2019-05-21 7:26 ` Minwoo Im
3 siblings, 0 replies; 5+ messages in thread
From: Minwoo Im @ 2019-05-21 7:26 UTC (permalink / raw)
Looks good to me.
Reviewed-by: Minwoo Im <minwoo.im at samsung.com>
^ permalink raw reply [flat|nested] 5+ messages in thread