From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH 1/4] nvme: have nvme_init_identify set ctrl->cap
Date: Sat, 20 Jul 2019 17:13:02 +0900 [thread overview]
Message-ID: <20190720081302.GE22395@minwoo-desktop> (raw)
In-Reply-To: <20190720075546.GB22395@minwoo-desktop>
Sagi,
I think the ctrl->cap is already configured frmo the following
functions which are all before the nvme_init_identify():
pci: nvme_pci_enable()
rdma: nvme_rdma_configure_admin_queue()
fc: nvme_fc_create_association()
Even it's already stored before it can be read again, but should we
really make it read again here?
Also I can see the 2nd patch description which tells that
nvme_init_identify() loaded the ctrl->cap value instead of the functinos
above.
If there's somethiig I missed here, Please let me know!
Thanks!
next prev parent reply other threads:[~2019-07-20 8:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 19:45 [PATCH 0/4] small set of nvme cleanups Sagi Grimberg
2019-07-19 19:45 ` [PATCH 1/4] nvme: have nvme_init_identify set ctrl->cap Sagi Grimberg
2019-07-20 7:55 ` Minwoo Im
2019-07-20 8:13 ` Minwoo Im [this message]
2019-07-20 21:15 ` Chaitanya Kulkarni
2019-07-19 19:45 ` [PATCH 2/4] nvme: move sqsize setting to the core Sagi Grimberg
2019-07-20 7:59 ` Minwoo Im
2019-07-20 21:18 ` Chaitanya Kulkarni
2019-07-19 19:45 ` [PATCH 3/4] nvme: don't pass cap to nvme_disable_ctrl Sagi Grimberg
2019-07-20 8:00 ` Minwoo Im
2019-07-20 21:22 ` Chaitanya Kulkarni
2019-07-19 19:45 ` [PATCH 4/4] nvme: don't pass cap to nvme_enable_ctrl Sagi Grimberg
2019-07-20 21:22 ` Chaitanya Kulkarni
2019-07-22 15:42 ` [PATCH 0/4] small set of nvme cleanups James Smart
2019-07-22 18:11 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190720081302.GE22395@minwoo-desktop \
--to=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox