From: james.smart@broadcom.com (James Smart)
Subject: [PATCH 0/4] small set of nvme cleanups
Date: Mon, 22 Jul 2019 08:42:44 -0700 [thread overview]
Message-ID: <3086fcef-efb2-85e4-4e36-2c5734cf3068@broadcom.com> (raw)
In-Reply-To: <20190719194546.24229-1-sagi@grimberg.me>
On 7/19/2019 12:45 PM, Sagi Grimberg wrote:
> Centralizes queue size settings for fabrics and
> removes redundant argument to nvme_disable/enable_ctrl.
>
> Sagi Grimberg (4):
> nvme: have nvme_init_identify set ctrl->cap
> nvme: move sqsize setting to the core
> nvme: don't pass cap to nvme_disable_ctrl
> nvme: don't pass cap to nvme_enable_ctrl
>
> drivers/nvme/host/core.c | 19 ++++++++++---------
> drivers/nvme/host/fc.c | 12 +-----------
> drivers/nvme/host/nvme.h | 4 ++--
> drivers/nvme/host/pci.c | 7 ++++---
> drivers/nvme/host/rdma.c | 15 ++-------------
> drivers/nvme/host/tcp.c | 13 ++-----------
> drivers/nvme/target/loop.c | 12 +-----------
> 7 files changed, 22 insertions(+), 60 deletions(-)
>
The changes look fine except for 1 main issue:? All of the nvmf
transports call nvme_enable_ctrl(), which still references ctrl->cap,
before they call nvme_init_identify().
-- james
next prev parent reply other threads:[~2019-07-22 15:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 19:45 [PATCH 0/4] small set of nvme cleanups Sagi Grimberg
2019-07-19 19:45 ` [PATCH 1/4] nvme: have nvme_init_identify set ctrl->cap Sagi Grimberg
2019-07-20 7:55 ` Minwoo Im
2019-07-20 8:13 ` Minwoo Im
2019-07-20 21:15 ` Chaitanya Kulkarni
2019-07-19 19:45 ` [PATCH 2/4] nvme: move sqsize setting to the core Sagi Grimberg
2019-07-20 7:59 ` Minwoo Im
2019-07-20 21:18 ` Chaitanya Kulkarni
2019-07-19 19:45 ` [PATCH 3/4] nvme: don't pass cap to nvme_disable_ctrl Sagi Grimberg
2019-07-20 8:00 ` Minwoo Im
2019-07-20 21:22 ` Chaitanya Kulkarni
2019-07-19 19:45 ` [PATCH 4/4] nvme: don't pass cap to nvme_enable_ctrl Sagi Grimberg
2019-07-20 21:22 ` Chaitanya Kulkarni
2019-07-22 15:42 ` James Smart [this message]
2019-07-22 18:11 ` [PATCH 0/4] small set of nvme cleanups Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3086fcef-efb2-85e4-4e36-2c5734cf3068@broadcom.com \
--to=james.smart@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox