* [PATCH] nvme-pci: Use dev_get_drvdata where possible
@ 2019-07-24 12:22 Chuhong Yuan
2019-07-24 18:15 ` Sagi Grimberg
2019-07-25 13:14 ` Minwoo Im
0 siblings, 2 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-07-24 12:22 UTC (permalink / raw)
Instead of using to_pci_dev + pci_get_drvdata,
use dev_get_drvdata to make code simpler.
Signed-off-by: Chuhong Yuan <hslester96 at gmail.com>
---
drivers/nvme/host/pci.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index bb970ca82517..3c6411f4d590 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2845,7 +2845,7 @@ static int nvme_set_power_state(struct nvme_ctrl *ctrl, u32 ps)
static int nvme_resume(struct device *dev)
{
- struct nvme_dev *ndev = pci_get_drvdata(to_pci_dev(dev));
+ struct nvme_dev *ndev = dev_get_drvdata(dev);
struct nvme_ctrl *ctrl = &ndev->ctrl;
if (pm_resume_via_firmware() || !ctrl->npss ||
@@ -2914,7 +2914,7 @@ static int nvme_suspend(struct device *dev)
static int nvme_simple_suspend(struct device *dev)
{
- struct nvme_dev *ndev = pci_get_drvdata(to_pci_dev(dev));
+ struct nvme_dev *ndev = dev_get_drvdata(dev);
nvme_dev_disable(ndev, true);
return 0;
@@ -2922,8 +2922,7 @@ static int nvme_simple_suspend(struct device *dev)
static int nvme_simple_resume(struct device *dev)
{
- struct pci_dev *pdev = to_pci_dev(dev);
- struct nvme_dev *ndev = pci_get_drvdata(pdev);
+ struct nvme_dev *ndev = dev_get_drvdata(dev);
nvme_reset_ctrl(&ndev->ctrl);
return 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvme-pci: Use dev_get_drvdata where possible
2019-07-24 12:22 [PATCH] nvme-pci: Use dev_get_drvdata where possible Chuhong Yuan
@ 2019-07-24 18:15 ` Sagi Grimberg
2019-07-25 13:14 ` Minwoo Im
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2019-07-24 18:15 UTC (permalink / raw)
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvme-pci: Use dev_get_drvdata where possible
2019-07-24 12:22 [PATCH] nvme-pci: Use dev_get_drvdata where possible Chuhong Yuan
2019-07-24 18:15 ` Sagi Grimberg
@ 2019-07-25 13:14 ` Minwoo Im
1 sibling, 0 replies; 3+ messages in thread
From: Minwoo Im @ 2019-07-25 13:14 UTC (permalink / raw)
On 19-07-24 20:22:35, Chuhong Yuan wrote:
> Instead of using to_pci_dev + pci_get_drvdata,
> use dev_get_drvdata to make code simpler.
>
> Signed-off-by: Chuhong Yuan <hslester96 at gmail.com>
This looks good to me.
Reviewed-by: Minwoo Im <minwoo.im.dev at gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-25 13:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-24 12:22 [PATCH] nvme-pci: Use dev_get_drvdata where possible Chuhong Yuan
2019-07-24 18:15 ` Sagi Grimberg
2019-07-25 13:14 ` Minwoo Im
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox