* [PATCH V2] nvme: Remove redundant assignment of cq vector
@ 2019-09-05 15:41 Israel Rukshin
2019-09-05 20:08 ` Sagi Grimberg
0 siblings, 1 reply; 3+ messages in thread
From: Israel Rukshin @ 2019-09-05 15:41 UTC (permalink / raw)
To: Linux-nvme; +Cc: Max Gurtovoy, Christoph Hellwig, Israel Rukshin, Sagi Grimberg
The cq vector is already assigned with the correct value.
Signed-off-by: Israel Rukshin <israelr@mellanox.com>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
---
drivers/nvme/host/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 9566ff9..419861b 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1551,7 +1551,6 @@ static int nvme_create_queue(struct nvme_queue *nvmeq, int qid, bool polled)
nvme_init_queue(nvmeq, qid);
if (!polled) {
- nvmeq->cq_vector = vector;
result = queue_request_irq(nvmeq);
if (result < 0)
goto release_sq;
--
1.8.3.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] nvme: Remove redundant assignment of cq vector
2019-09-05 15:41 [PATCH V2] nvme: Remove redundant assignment of cq vector Israel Rukshin
@ 2019-09-05 20:08 ` Sagi Grimberg
2019-09-05 20:08 ` Keith Busch
0 siblings, 1 reply; 3+ messages in thread
From: Sagi Grimberg @ 2019-09-05 20:08 UTC (permalink / raw)
To: Israel Rukshin, Linux-nvme; +Cc: Max Gurtovoy, Christoph Hellwig
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
I want a formal review from Keith to apply to nvme-5.4.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] nvme: Remove redundant assignment of cq vector
2019-09-05 20:08 ` Sagi Grimberg
@ 2019-09-05 20:08 ` Keith Busch
0 siblings, 0 replies; 3+ messages in thread
From: Keith Busch @ 2019-09-05 20:08 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: Israel Rukshin, Christoph Hellwig, Linux-nvme, Max Gurtovoy
On Thu, Sep 05, 2019 at 01:08:18PM -0700, Sagi Grimberg wrote:
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
>
> I want a formal review from Keith to apply to nvme-5.4.
Sure thing. Patch looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-05 20:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-05 15:41 [PATCH V2] nvme: Remove redundant assignment of cq vector Israel Rukshin
2019-09-05 20:08 ` Sagi Grimberg
2019-09-05 20:08 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox