From: Keith Busch <kbusch@kernel.org>
To: Balbir Singh <sblbir@amzn.com>
Cc: axboe@fb.com, hch@lst.de, linux-nvme@lists.infradead.org,
sagi@grimberg.me
Subject: Re: [PATCH v4] nvme/host/pci: Fix a race in controller removal
Date: Tue, 17 Sep 2019 20:15:41 -0600 [thread overview]
Message-ID: <20190918021541.GA45690@C02WT3WMHTD6> (raw)
In-Reply-To: <20190918002720.18330-1-sblbir@amzn.com>
On Wed, Sep 18, 2019 at 12:27:20AM +0000, Balbir Singh wrote:
> User space programs like udevd may try to read to partitions at the
> same time the driver detects a namespace is unusable, and may deadlock
> if revalidate_disk() is called while such a process is waiting to
> enter the frozen queue. On detecting a dead namespace, move the disk
> revalidate after unblocking dispatchers that may be holding bd_butex.
Patch looks fine.
Reviewed-by: Keith Busch <kbusch@kernel.org>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2019-09-18 2:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 0:27 [PATCH v4] nvme/host/pci: Fix a race in controller removal Balbir Singh
2019-09-18 2:15 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918021541.GA45690@C02WT3WMHTD6 \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sblbir@amzn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox